Fixed failing filenames (For Windows)#10
Open
d-a-n-g-l-i-n-g-p-o-i-n-t-e-r wants to merge 2 commits intoscrimba:mainfrom
Open
Fixed failing filenames (For Windows)#10d-a-n-g-l-i-n-g-p-o-i-n-t-e-r wants to merge 2 commits intoscrimba:mainfrom
d-a-n-g-l-i-n-g-p-o-i-n-t-e-r wants to merge 2 commits intoscrimba:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloning repository on windows machine causes a problem with invalid paths. Because of backwards compatibility hula Windows, specifically Win32 API (as far as I understand) strips trailing whitespaces and dots making it unable to sort out the filenames.
In summary trailing whitespaces in folder names were stripped, and trailing dots(...) were converted (..._), which is not ideal, but at least makes it work and causes no issues. Nothing besides changing filenames has been done.