Merge pull request #31 from script-development/fix/adapter-store-setbyid-reactivity

Fix setById reactivity by invalidating adapted cache

Author: Goosterhof

.github/workflows/publish.yml

@@ -41,7 +41,7 @@ jobs:
       - uses: actions/download-artifact@v4
         with:
           name: build-output
-          path: .
+          path: packages
       - run: npm ci --ignore-scripts
       - run: npx changeset publish
         env:

packages/adapter-store/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@script-development/fs-adapter-store",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "Reactive adapter-store pattern with domain state management and CRUD resource adapters",
   "homepage": "https://packages.script.nl/packages/adapter-store",
   "license": "MIT",

packages/adapter-store/src/adapter-store.ts

@@ -44,6 +44,7 @@ export const createAdapterStoreModule = <
   const setById = (item: T): void => {
     state.value = { ...state.value, [item.id]: Object.freeze(item) };
     storageService.put(domainName, state.value);
+    adaptedCache.delete(item.id);
   };
 
   const deleteById = (id: number): void => {

packages/adapter-store/tests/adapter-store.spec.ts

@@ -16,7 +16,7 @@ import type { Ref } from "vue";
 import { EntryNotFoundError } from "../src/errors";
 import { createAdapterStoreModule } from "../src/adapter-store";
 import { describe, expect, it, vi } from "vitest";
-import { ref } from "vue";
+import { computed, ref } from "vue";
 
 type TestNew = Omit<TestItem, "id">;
 type TestStorageService = Pick<StorageService, "get" | "put">;
@@ -771,7 +771,7 @@ describe("createAdapterStoreModule", () => {
       expect(firstAccess).toBe(secondAccess);
     });
 
-    it("should return the same adapted object after setById, with reactive properties reflecting the update", async () => {
+    it("should return a new adapted object after setById, with properties reflecting the update", async () => {
       // Arrange
       const httpService: Pick<HttpService, "getRequest"> = { getRequest: vi.fn() };
       const storageService: TestStorageService = { put: vi.fn(), get: vi.fn().mockReturnValue({}) };
@@ -811,12 +811,58 @@ describe("createAdapterStoreModule", () => {
       });
       const afterUpdate = store.getById(1).value;
 
-      // Assert — same adapted object reference (reactive getters, no cache invalidation)
-      expect(beforeUpdate).toBe(afterUpdate);
-      // Display properties reflect the updated store data via getter
+      // Assert — new adapted object reference (cache invalidated by setById)
+      expect(beforeUpdate).not.toBe(afterUpdate);
+      // Display properties reflect the updated store data
       expect(afterUpdate?.name).toBe("Updated");
     });
 
+    it("should propagate setById changes through computed chain", async () => {
+      // Arrange
+      const httpService: Pick<HttpService, "getRequest"> = { getRequest: vi.fn() };
+      const storageService: TestStorageService = { put: vi.fn(), get: vi.fn().mockReturnValue({}) };
+      const loadingService: TestLoadingService = {
+        ensureLoadingFinished: vi.fn().mockResolvedValue(undefined),
+      };
+      const { adapter, getCapturedStoreModule } = createCapturingAdapter();
+      const config: AdapterStoreConfig<TestItem, TestAdapted, TestNewAdapted> = {
+        domainName: "test-items",
+        adapter,
+        httpService,
+        storageService,
+        loadingService,
+      };
+      const items: TestItem[] = [
+        {
+          id: 1,
+          name: "Original",
+          createdAt: "2024-01-01T00:00:00Z",
+          updatedAt: "2024-01-01T00:00:00Z",
+        },
+      ];
+      vi.mocked(httpService.getRequest).mockResolvedValue({ data: items } as AxiosResponse<
+        TestItem[]
+      >);
+      const store = createAdapterStoreModule(config);
+      await store.retrieveAll();
+
+      // A downstream computed that wraps getById — mirrors how Vue components consume stores
+      const derivedName = computed(() => store.getById(1).value?.name);
+      expect(derivedName.value).toBe("Original");
+
+      // Act — simulate a store update (e.g. from an update response)
+      const storeModule = getCapturedStoreModule() as unknown as AdapterStoreModule<TestItem>;
+      storeModule.setById({
+        id: 1,
+        name: "Updated",
+        createdAt: "2024-01-01T00:00:00Z",
+        updatedAt: "2024-01-02T00:00:00Z",
+      });
+
+      // Assert — the downstream computed must re-evaluate
+      expect(derivedName.value).toBe("Updated");
+    });
+
     it("should clear adapted cache on deleteById", async () => {
       // Arrange
       const httpService: Pick<HttpService, "getRequest"> = { getRequest: vi.fn() };

packages/http/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@script-development/fs-http",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "Framework-agnostic HTTP service factory with middleware architecture",
   "homepage": "https://packages.script.nl/packages/http",
   "license": "MIT",