fix(toast): wrap container in single root element#15
Merged
Conversation
The render function returned a fragment (array of VNodes), causing Vue to silently drop fallthrough attributes. Positioning classes applied on <component :is="ToastContainerComponent" /> had no effect. Wrapping in a <div> enables proper attribute inheritance. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToastContainerComponentrendered a fragment (array of VNodes), causing Vue to silently drop all fallthrough attributes<component :is="ToastContainerComponent" />had no effect — toasts appeared in normal document flow instead of fixed position<div>gives the component a single root, enabling proper Vue attribute inheritanceRoot cause
Vue's fallthrough attributes only work on single-root components. Fragment components silently discard them.
Test plan
🤖 Generated with Claude Code