test(adapter-store): add reactivity guarantee for getOrFailById#20
Merged
Conversation
Verify that adapted items returned by getOrFailById reflect store updates via Object.defineProperty getters. After setById replaces state, the same adapted object's properties return fresh data — proving the getter-based reactivity chain works end-to-end. This was the missing coverage gap: getById had a reactivity test but getOrFailById did not, despite using the same getter mechanism. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Deploying fs-packages with
|
| Latest commit: |
954d5b7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ead8625c.fs-packages.pages.dev |
| Branch Preview URL: | https://test-adapter-store-reactivit.fs-packages.pages.dev |
GHSA-3p68-rc4w-qgx5: Axios <1.15.0 has a NO_PROXY hostname normalization bypass that leads to SSRF. Bumps to 1.15.0 in both fs-http (direct dep) and fs-loading (dev dep). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getOrFailByIdreturns reactive adapted itemssetByIdupdates the store, the same adapted object's properties return fresh data viaObject.definePropertygettersContext
This was discovered while investigating a reactivity bug in kendo's local adapter-store. The Armory's getter-based pattern is already reactive, but had no test proving it. This test closes that coverage gap and guards against regression.
Test plan
npx vitest run— 405 tests pass (404 → 405)--reporter=verbose:✓ should return reactive adapted item that reflects store updates🤖 Generated with Claude Code