chore: npm audit fix — bump brace-expansion + ws transitive devDeps#95
Closed
Goosterhof wants to merge 1 commit into
Closed
chore: npm audit fix — bump brace-expansion + ws transitive devDeps#95Goosterhof wants to merge 1 commit into
Goosterhof wants to merge 1 commit into
Conversation
Two moderate-severity advisories landed in the GitHub Advisory Database between 2026-05-18 and 2026-05-20, breaking `npm audit` on every PR that ran CI in that window (#87, #90, #91, #92, #94 plus dependabot). Diagnosis: CI failures show on PRs with trivial diffs (e.g. #94 is a 1-line .gitignore) → failure is in the baseline, not the PR diffs. - brace-expansion 5.0.5 → 5.0.6 — DoS in numeric range (GHSA-jxxr-4gwj-5jf2) - ws 8.20.0 → 8.20.1 — uninitialized memory disclosure (GHSA-58qx-3vcg-4xpx) Both are dev-only transitive deps. Patch-level bumps, no public-API ripple. `npm audit fix` produces the minimal lockfile delta. Verified locally: - npm audit: 0 vulnerabilities - format:check, lint, build, typecheck, test:coverage all green - lint:pkg still fails on publint sideEffects suggestion — distinct baseline issue addressed by PR #88 (queue #70) Closes the npm-audit half of envelope #23.
Deploying fs-packages with
|
| Latest commit: |
5bfd131
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6a9a0609.fs-packages.pages.dev |
| Branch Preview URL: | https://fix-npm-audit-baseline-drift.fs-packages.pages.dev |
5 tasks
Contributor
PR Reviewer · 10/10 · PASS
Findings
Actionmerge-ready |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brace-expansion5.0.5 → 5.0.6 — DoS via numeric range (GHSA-jxxr-4gwj-5jf2)ws8.20.0 → 8.20.1 — uninitialized memory disclosure (GHSA-58qx-3vcg-4xpx)npm audit fix. Lockfile-only change, nopackage.jsontouched.Context
Both advisories landed in the GitHub Advisory Database between 2026-05-18 and 2026-05-20. CI's
npm auditstep exits 1 on any moderate advisory, so every PR opened in that window inherits the failure — even PRs whose own diff is trivial (PR #94 is one line in.gitignore). Last green CI onmain: 2026-05-15 (PR #88).This fixes the
npm audithalf of the baseline. Thelint:pkgstep is also failing on a separate publint-sideEffects regression — PR #88 (queue #70) is the canonical fix for that and should rebase + merge after this lands.Test plan
npm audit→ 0 vulnerabilitiesnpm run format:checknpm run lintnpm run buildnpm run typechecknpm run test:coverage(528/528 passed)🤖 Generated with Claude Code