Skip to content

ci: add coverage --min=95 gate with pcov driver #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Goosterhof wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: add coverage --min=95 gate with pcov driver #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
uses: shivammathur/setup-php@728c6c6b8cf02c2e48117716a91ee48313958a19 # v2
with:
php-version: ${{ matrix.php }}
coverage: none
coverage: pcov
tools: composer:v2

- name: Install dependencies
Expand All @@ -36,7 +36,7 @@ jobs:
run: composer phpstan

- name: Tests
run: composer test
run: composer test:coverage

@Goosterhof Goosterhof Jul 14, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit (Confirmed, introduced) — composer test:coverage (pcov-instrumented) now runs on both matrix legs (8.4, 8.5) against the identical src/ tree — coverage is a property of the test suite, not the PHP version, so this doubles pcov instrumentation for no additional signal. Harmless at current runtime (23–24s/leg); if the suite grows, scope coverage collection to a single leg (e.g. if: matrix.php == '8.4') and leave the other leg on driverless composer test.


# Aggregate tracked by the town-crier trial (TC-0069), intended as the single
# required check (the matrix legs stop being individually required).
Expand Down
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
},
"scripts": {
"test": "pest",
"test:coverage": "pest --coverage --min=95",

@Goosterhof Goosterhof Jul 14, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Minor (Confirmed, introduced) — floor is 95, PR body claims measured 95.5% — a 0.5pp cushion. The next unrelated PR that adds even a handful of untested lines to src/ trips this gate on a package with no active feature work in flight, turning a hygiene gate into unplanned CI friction on someone else's PR. Either set the floor a few points under the measured value (e.g. 90) to leave ratchet headroom, or confirm the tight value is a deliberate ratchet-toward-100 posture so the next contributor isn't surprised by a red build unrelated to their change.

"phpstan": "phpstan analyse",
"format": "pint",
"format:check": "pint --test"
Expand Down