Skip to content

ci(town-crier): re-announce on push (synchronize + head_oid) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasperboerhof wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −3
Open

ci(town-crier): re-announce on push (synchronize + head_oid) #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/announce-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,15 @@ permissions: {}

on:
pull_request:
types: [labeled, unlabeled, closed]
# labeled -> first announce; synchronize -> re-announce each new commit (re-review on push);
# unlabeled/closed -> resolve (de-announce). A synchronize on an unlabelled PR is ignored by the if.
types: [labeled, synchronize, unlabeled, closed]

jobs:
announce:
if: github.event.action == 'labeled' && github.event.label.name == 'Agent Review Requested'
if: >-
(github.event.action == 'labeled' && github.event.label.name == 'Agent Review Requested') ||
(github.event.action == 'synchronize' && contains(github.event.pull_request.labels.*.name, 'Agent Review Requested'))
runs-on: ubuntu-latest
steps:
- name: Announce to the crier
Expand All @@ -37,6 +41,9 @@ jobs:
REPO: ${{ github.repository }}
TITLE: ${{ github.event.pull_request.title }}
REQUESTER: ${{ github.event.pull_request.user.login }}
# The head SHA is the change detector: a re-announce with the same head is a no-op on the
# bus; a new head reopens the thread for a fresh review round.
HEAD_OID: ${{ github.event.pull_request.head.sha }}
run: |
# Missing provisioning is a config error — fail LOUD so it can't pass silently.
if [ -z "$CRIER_URL" ] || [ -z "$CRIER_TOKEN" ]; then
Expand All @@ -53,7 +60,8 @@ jobs:
--arg repo "$REPO" \
--arg title "$TITLE" \
--arg requester "$REQUESTER" \
'{pr_url:$pr, repo:$repo, title:$title, requester:$requester}')" \
--arg head_oid "$HEAD_OID" \
'{pr_url:$pr, repo:$repo, title:$title, requester:$requester, head_oid:$head_oid}')" \
|| echo "::warning::town-crier announce failed (transient bus issue?) — not blocking the PR"

resolve:
Expand Down
Loading