update

Author: cyfung1031

packages/filesystem/baidu/baidu.test.ts

@@ -100,10 +100,13 @@ describe("BaiduFileSystem", () => {
     expect(String((requestSpy.mock.calls[2][1] as RequestInit).body)).toContain("rtype=0");
   });
 
-  it("writer should surface Baidu createOnly rejection as conflict", async () => {
+  it("writer should surface Baidu createOnly exists rejection as conflict", async () => {
     const fs = new BaiduFileSystem("/apps", "token");
     vi.spyOn(fs, "list").mockResolvedValue([]);
-    vi.spyOn(fs, "request").mockResolvedValueOnce({ errno: -8, errmsg: "file exists" });
+    vi.spyOn(fs, "request").mockResolvedValueOnce({
+      errno: -8,
+      errmsg: "file exists",
+    });
 
     const writer = await fs.create("test.txt", { createOnly: true });
 
@@ -113,6 +116,38 @@ describe("BaiduFileSystem", () => {
     });
   });
 
+  it("writer should surface Baidu createOnly duplicate name rejection as conflict", async () => {
+    const fs = new BaiduFileSystem("/apps", "token");
+    vi.spyOn(fs, "list").mockResolvedValue([]);
+    vi.spyOn(fs, "request").mockResolvedValueOnce({
+      errno: 31061,
+      errmsg: "duplicate name",
+    });
+
+    const writer = await fs.create("test.txt", { createOnly: true });
+
+    await expect(writer.write("content")).rejects.toMatchObject({
+      provider: "baidu",
+      conflict: true,
+      code: "31061",
+    });
+  });
+
+  it("writer should not classify non-exists Baidu createOnly errno as conflict", async () => {
+    const fs = new BaiduFileSystem("/apps", "token");
+    vi.spyOn(fs, "list").mockResolvedValue([]);
+    vi.spyOn(fs, "request").mockResolvedValueOnce({
+      errno: 111,
+      errmsg: "quota exceeded",
+    });
+
+    const writer = await fs.create("test.txt", { createOnly: true });
+
+    await expect(writer.write("content")).rejects.not.toMatchObject({
+      conflict: true,
+    });
+  });
+
   it("writer should reject expectedDigest when remote digest changed", async () => {
     const fs = new BaiduFileSystem("/apps", "token");
     vi.spyOn(fs, "list").mockResolvedValue([

packages/filesystem/baidu/rw.ts

@@ -135,16 +135,21 @@ export class BaiduFileWriter implements FileWriter {
   }
 
   private throwCreateOnlyConflict(data: any): void {
-    if (!this.opts?.createOnly) {
+    if (!this.opts?.createOnly || !this.isBaiduCreateConflict(data)) {
       return;
     }
-    throw fileConflictError("baidu", `File already exists or createOnly write was rejected: ${this.path}`, {
+    throw fileConflictError("baidu", `File already exists: ${this.path}`, {
       status: 409,
       code: String(data.errno),
       raw: data,
     });
   }
 
+  private isBaiduCreateConflict(data: any): boolean {
+    const errno = String(data?.errno);
+    return errno === "-8" || errno === "31061";
+  }
+
   private async checkWritePrecondition(): Promise<void> {
     if (!this.opts?.expectedDigest && !this.opts?.createOnly) {
       return;