Fix leaf recursion debug constraint mismatches#1368
Draft
kunxian-xia wants to merge 1 commit into
Draft
Conversation
fd61a01 to
dc1b448
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the current leaf-recursion debug fixes developed in a separate worktree on
fix/leaf-recursion-debug.Fixed debug-local bus/AIR mismatches:
TowerLayerInputBusimbalance is gone (Bus 28).StartingTidxBusimbalance is gone (Bus 26) by aligning proof-shape preflight cursor generation withProofShapeAir's recurrence.LookupChallengeBusimbalance is gone (Bus 24) by rehydrating VmPvs lookup alpha/beta from the incoming transcript log before proof-shape trace generation.ProofShapeAir<4, 8>row-local failure is no longer the active blocker.The work also includes transcript/public-value ordering and tower transcript/sumcheck alignment changes needed to reach the current debug state.
Current Status
This is intentionally a draft: the single-shard debug gate still fails at LogUp equality.
Current focused remaining failure:
Bus 23/ForkedTranscriptBus, betweenForkedTranscriptAirandProofShapeAir.ForkedTranscriptAircurrently emits an incomplete first-row fork-local approximation. It should publish actual fork-local transcript log entries keyed bylocal_tidx, soProofShapeAircan consume the fork prelude and sampled challenge entries consistently.Testing
Passed:
cargo fmtcargo test continuation::tests::prover_integration::agg_prover_single_shard --no-runRun and still failing as expected at the next remaining bus mismatch:
CENO_RECURSION_V2_FIXTURE_DIR=/Users/xkx/Blockchain/ceno/ceno_recursion_v2/src/imported \ RUST_BACKTRACE=1 \ RUST_LOG=ceno_recursion_v2=info \ RUST_MIN_STACK=33554432 \ cargo test continuation::tests::prover_integration::agg_prover_single_shard -- --nocaptureLatest debug bus summary after the committed fixes no longer includes buses
28,26, or24; it now includesBus 23as the next focused local mismatch.