Skip to content

Split ShardRam EC tree into a dedicated circuit #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hero78119 merged 4 commits into from
Jun 30, 2026
Merged

Split ShardRam EC tree into a dedicated circuit #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc27512
Split ShardRam EC tree circuit
hero78119 Jun 23, 2026
8162e6f
Merge remote-tracking branch 'upstream/master' into feat/shardram_cir…
hero78119 Jun 23, 2026
de5cc96
correct opt: half size on poseidon and keep ecc sum as binary tree
hero78119 Jun 23, 2026
cbc94a7
Merge remote-tracking branch 'upstream/master' into feat/shardram_cir…
hero78119 Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions ceno_zkvm/src/e2e.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ use crate::{
ZKVMWitnesses,
},
tables::{
MemFinalRecord, MemInitRecord, ProgramTableCircuit, ProgramTableConfig, ShardRamCircuit,
TableCircuit,
MemFinalRecord, MemInitRecord, ProgramTableCircuit, ProgramTableConfig,
ShardRamEcTreeCircuit, TableCircuit,
},
};
use ceno_emul::{
Expand Down Expand Up @@ -1682,20 +1682,21 @@ pub fn generate_witness<'a, E: ExtensionField>(
)
}).unwrap();

if let Some(shard_ram_witnesses) =
zkvm_witness.get_witness(&ShardRamCircuit::<E>::name())
if let Some(shard_ram_ec_tree_witnesses) =
zkvm_witness.get_witness(&ShardRamEcTreeCircuit::<E>::name())
{
info_span!("shard_ram_ec_sum").in_scope(|| {
let shard_ram_ec_sum: SepticPoint<E::BaseField> = shard_ram_witnesses
.iter()
.filter(|shard_ram_witness| shard_ram_witness.num_instances[0] > 0)
.map(|shard_ram_witness| {
ShardRamCircuit::<E>::extract_ec_sum(
&system_config.mmu_config.ram_bus_circuit,
&shard_ram_witness.witness_rmms[0],
)
})
.sum();
let shard_ram_ec_sum: SepticPoint<E::BaseField> =
shard_ram_ec_tree_witnesses
.iter()
.filter(|shard_ram_witness| shard_ram_witness.num_instances[0] > 0)
.map(|shard_ram_witness| {
ShardRamEcTreeCircuit::<E>::extract_ec_sum(
&system_config.mmu_config.ram_bus_ec_tree_circuit,
&shard_ram_witness.witness_rmms[0],
)
})
.sum();

let xy = shard_ram_ec_sum
.x
Expand Down
Loading
Loading