Skip to content

Commit 167f26e

Browse files
georgehaoThegaram
andauthored
fix: use empty access list if eth_createAccessList returns error (#1799)
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
1 parent 9b2b5e0 commit 167f26e

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

common/version/version.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
"runtime/debug"
66
)
77

8-
var tag = "v4.7.12"
8+
var tag = "v4.7.13"
99

1010
var commit = func() string {
1111
if info, ok := debug.ReadBuildInfo(); ok {

rollup/internal/controller/sender/estimategas.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package sender
22

33
import (
4-
"errors"
54
"fmt"
65
"math/big"
76

@@ -134,11 +133,15 @@ func (s *Sender) estimateGasLimit(to *common.Address, data []byte, sidecar *type
134133
accessList, gasLimitWithAccessList, errStr, rpcErr := s.gethClient.CreateAccessList(s.ctx, msg)
135134
if rpcErr != nil {
136135
log.Error("CreateAccessList RPC error", "error", rpcErr)
137-
return gasLimitWithoutAccessList, nil, rpcErr
136+
// We ignore errors from eth_createAccessList and proceed
137+
// with sending the transaction without an access list.
138+
return gasLimitWithoutAccessList, nil, nil
138139
}
139140
if errStr != "" {
141+
// We ignore errors from eth_createAccessList and proceed
142+
// with sending the transaction without an access list.
140143
log.Error("CreateAccessList reported error", "error", errStr)
141-
return gasLimitWithoutAccessList, nil, errors.New(errStr)
144+
return gasLimitWithoutAccessList, nil, nil
142145
}
143146

144147
// Fine-tune accessList because 'to' address is automatically included in the access list by the Ethereum protocol: https://github.com/ethereum/go-ethereum/blob/v1.13.10/core/state/statedb.go#L1322

0 commit comments

Comments
 (0)