ci: broaden zarr UnstableSpecificationWarning filter to match Struct(…) repr#2403
Merged
Merged
Conversation
……) repr zarr 3.1.7.dev44 changed the data-type repr from "Structured" to "Struct(fields=…)", so the existing `.*Structured` message filter stopped firing under `--strict-warnings`. Widen the pattern to `.*Struct`, which matches both forms without loosening the category filter.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2403 +/- ##
==========================================
- Coverage 87.43% 85.48% -1.96%
==========================================
Files 49 49
Lines 7728 7728
==========================================
- Hits 6757 6606 -151
- Misses 971 1122 +151 |
ilan-gold
pushed a commit
that referenced
this pull request
Apr 22, 2026
…cationWarning` filter to match `Struct(…)` repr) (#2404) Co-authored-by: Dominik J. Otto <dominik.otto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zarr
3.1.7.dev44changed its data-typereprfromStructuredtoStruct(fields=…), so the existing.*Structuredmessage filter inpyproject.toml(added in 926667b) no longer matches. Under--strict-warnings, theUnstableSpecificationWarningnow propagates and fails tests using compound dtypes inuns(e.g.pbmc68k).Widening the pattern to
.*Structmatches both the old (Structured) and new (Struct(fields=…)) forms, with the category filter (zarr.core.dtype.common.UnstableSpecificationWarning) unchanged.Why main looks green
Main's last CI run was pinned (by install-time resolution) to
zarr 3.1.7.dev42, which still used the old repr. Any fresh run on main against the current pre-release reproduces the failure; main is sitting on a stale green.Failing CI run (observed on #2236)
test (hatch-test.pre, 3.14, --strict-warnings, zarr_io)tests/test_readwrite.py::test_scanpy_pbmc68k[zarr3]tests/test_io_partial.py::test_read_partial_adata[zarr3]UnstableSpecificationWarning: The data type (Struct(fields=((...)))) does not have a Zarr V3 specificationTest plan
ci:prefix → release-note check exemptedhatch-test.prezarr_io CI passes against current pre-release zarr