Skip to content

Add pertpy & decoupler to test matrix#17

Merged
Zethson merged 10 commits into
mainfrom
Zethson-patch-1
Jun 30, 2025
Merged

Add pertpy & decoupler to test matrix#17
Zethson merged 10 commits into
mainfrom
Zethson-patch-1

Conversation

@Zethson
Copy link
Copy Markdown
Member

@Zethson Zethson commented May 22, 2025

  • Adds pertpy and decoupler to the test matrix
  • Allows for optional extras to be specified per package
  • Adds a README

@Zethson Zethson marked this pull request as draft May 22, 2025 13:35
@flying-sheep
Copy link
Copy Markdown
Member

Feel free to reject!

Why would we? it's good to add more here!

Ideally, these tests would be skipped if they're not available. It's a TODO of mine.

let's wait for that, there's little utility in adding tests that can't succeed yet

@Zethson Zethson changed the title Add pertpy to test matrix Add pertpy & decoupler to test matrix Jun 20, 2025
Zethson added 6 commits June 20, 2025 16:09
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
@Zethson Zethson marked this pull request as ready for review June 20, 2025 14:33
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
@Zethson
Copy link
Copy Markdown
Member Author

Zethson commented Jun 20, 2025

@flying-sheep added an extras matrix to have the DE extra available for pertpy. This fails as expected because scverse/PyDESeq2#387 is not yet resolved. The pertpy tests have run through without errors without the extra but I think it's nice that we cover pydeseq2 through this extra. Lots of functionality of pertpy is gated behind it.

@PauBadiaM the decoupler errors should be looked into

@Zethson Zethson requested a review from flying-sheep June 20, 2025 14:40
@PauBadiaM
Copy link
Copy Markdown

@Zethson, the error was caused because in a test I used scipy.sparse.coo_matrix to test if decoupler works with multiple sparse formats. This worked for older anndata versions. I have changed it to scipy.sparse.csc_matrix to make it compatible.

@Zethson Zethson requested a review from ilan-gold June 30, 2025 10:32
Comment thread .github/workflows/integration-test.yml
Comment thread .github/workflows/integration-test.yml
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
@Zethson
Copy link
Copy Markdown
Member Author

Zethson commented Jun 30, 2025

@PauBadiaM the failures are coming from Statsmodels. We need to pin scipy to <1.16 in decoupler, please.

Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
@Zethson Zethson merged commit 4d5a482 into main Jun 30, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants