feat: add snapatac2#18
Merged
Merged
Conversation
Contributor
Author
Zethson
approved these changes
Oct 31, 2025
Member
Zethson
left a comment
Zethson
left a comment
There was a problem hiding this comment.
Does LFS cache really result in a speedup here? There aren't that many big binaries right?
But it doesn't really matter
Contributor
Author
Well we can't opt-out of LFS because Kai uses it (or can we?). And if we use the github action checkout, we'll check out that single 3MB file, which is the largest one. But if we run these once a day for a month, that's 200MB of his quota (because there are two runs, one for each python version): https://docs.github.com/en/billing/concepts/product-billing/git-lfs#free-use-of-git-lfs, granted he has 10GB. So this is more out of respect for his repo than anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See scverse/SnapATAC2#424 (comment) for why we had to do the directory fixes. The
doesn't let you specify a path so I'm not sure how to get around this. So now we just checkout each repo into the root.