add score_genes support for Dask#408
Merged
Merged
Conversation
flying-sheep
approved these changes
Jul 22, 2025
Member
flying-sheep
left a comment
flying-sheep
left a comment
There was a problem hiding this comment.
looks good! I think csc support would be very easy and a few minor simplifications possible, otherwise great!
Comment on lines
+94
to
+97
| if isinstance(X._meta, csc_matrix_cpu): | ||
| pass | ||
| meta = _meta_sparse if isinstance(X._meta, csr_matrix_cpu) else _meta_dense | ||
| X = X.map_blocks(X_to_GPU, meta=meta(X.dtype)) | ||
| elif isinstance(X._meta, csr_matrix_gpu) or isinstance(X._meta, cp.ndarray): | ||
| pass |
Member
There was a problem hiding this comment.
Suggested change
| if isinstance(X._meta, csc_matrix_cpu): | |
| pass | |
| meta = _meta_sparse if isinstance(X._meta, csr_matrix_cpu) else _meta_dense | |
| X = X.map_blocks(X_to_GPU, meta=meta(X.dtype)) | |
| elif isinstance(X._meta, csr_matrix_gpu) or isinstance(X._meta, cp.ndarray): | |
| pass | |
| if isinstance(X._meta, csc_matrix_cpu | csr_matrix_gpu | cp.ndarray): | |
| pass |
Comment on lines
-168
to
+165
| return cp.vstack([mean, var]) | ||
| return cp.stack([mean, var], axis=1) |
Member
There was a problem hiding this comment.
I’m curious: why the axis switch? is this more local?
Member
Author
There was a problem hiding this comment.
this works the other for some reason doesn't
Member
Author
|
I have csc support for non dask arrays. But for the moment I don't support dask csc in general also because of cupy being weird about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.