(feat): add dask documentation#216
Merged
Merged
Conversation
ilan-gold
commented
Apr 29, 2025
Comment on lines
+81
to
+84
| In the {doc}`multi-gpu showcase notebook for rapids-singlecell <rapids-singlecell:notebooks/06-multi_gpu_show>`, {meth}`dask.array.Array.persist` appears across the notebook. | ||
| This loads the entire dataset into memory while keeping the representation as a dask array. | ||
| Thus, lazy computation still works but only necessitates a single read into memory. | ||
| The catch is that you have enough memory to use `persist`. |
Contributor
Author
There was a problem hiding this comment.
@Intron7 can you review this section specifically? feel free to do more, but this one would be great if you only have a bit of time
flying-sheep
approved these changes
May 5, 2025
Member
There was a problem hiding this comment.
Looks great! Maybe link 1–2 of Dask’s guides/tutorials, especially in the “Custom block-wise array operations” section.
I just directly committed other things I saw, please check that everything I did is OK with you:
- I reverted the addition of
hatch.toml, as we already have thedocsenv defined inpyproject.toml. I moved your additions over there instead. - I replaced the bold paragraphs acting as headers with actual headers.
- I fixed a link to our code (I’m pretty sure I got the line number you meant right).
- I fixed some typos.
Intron7
reviewed
May 14, 2025
Co-authored-by: Severin Dicks <37635888+Intron7@users.noreply.github.com>
Co-authored-by: Severin Dicks <37635888+Intron7@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3346