Skip to content

feat: scvix reformat#3827

Open
ori-kron-wis wants to merge 26 commits into
mainfrom
Ori-scvix_da_omer2_rebase_upstream
Open

feat: scvix reformat#3827
ori-kron-wis wants to merge 26 commits into
mainfrom
Ori-scvix_da_omer2_rebase_upstream

Conversation

@ori-kron-wis

Copy link
Copy Markdown
Collaborator

No description provided.

@ori-kron-wis ori-kron-wis self-assigned this May 28, 2026
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.4.x on-merge: backport to 1.4.x label May 28, 2026
@ori-kron-wis ori-kron-wis changed the title Ori scvix da omer2 rebase upstream feat: Ori scvix da omer2 rebase upstream May 28, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff766c3ab9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/scvi/external/__init__.py
@ori-kron-wis ori-kron-wis changed the title feat: Ori scvix da omer2 rebase upstream feat: scvix reformat May 28, 2026
@ori-kron-wis ori-kron-wis requested a review from canergen May 28, 2026 10:20
@codecov

codecov Bot commented May 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.19814% with 115 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.28%. Comparing base (937568a) to head (ab447bb).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/scvi/external/scvix/_module.py 78.11% 65 Missing ⚠️
src/scvi/external/scvix/_components.py 78.70% 33 Missing ⚠️
src/scvi/external/scvix/_trainingplans.py 87.09% 12 Missing ⚠️
src/scvi/external/scvix/_model.py 94.84% 5 Missing ⚠️

❌ Your patch check has failed because the patch coverage (82.19%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (937568a) and HEAD (ab447bb). Click for more details.

HEAD has 15 uploads less than BASE
Flag BASE (937568a) HEAD (ab447bb)
integration 18 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3827      +/-   ##
==========================================
- Coverage   88.54%   83.28%   -5.27%     
==========================================
  Files         231      250      +19     
  Lines       23064    26021    +2957     
==========================================
+ Hits        20423    21672    +1249     
- Misses       2641     4349    +1708     
Flag Coverage Δ
integration 74.73% <82.19%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scvi/external/__init__.py 100.00% <100.00%> (ø)
src/scvi/external/scvix/__init__.py 100.00% <100.00%> (ø)
src/scvi/external/scvix/_model.py 94.84% <94.84%> (ø)
src/scvi/external/scvix/_trainingplans.py 87.09% <87.09%> (ø)
src/scvi/external/scvix/_components.py 78.70% <78.70%> (ø)
src/scvi/external/scvix/_module.py 78.11% <78.11%> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis added on-merge: backport to 1.5.x on-merge: backport to 1.5.x and removed on-merge: backport to 1.4.x on-merge: backport to 1.4.x labels Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on-merge: backport to 1.5.x on-merge: backport to 1.5.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants