Skip to content

Backport PR #3880 on branch 1.4.x (Fix: Extract some methods from FCLayers for easier inheritance)#3898

Merged
ori-kron-wis merged 1 commit into
scverse:1.4.xfrom
meeseeksmachine:auto-backport-of-pr-3880-on-1.4.x
Jun 30, 2026
Merged

Backport PR #3880 on branch 1.4.x (Fix: Extract some methods from FCLayers for easier inheritance)#3898
ori-kron-wis merged 1 commit into
scverse:1.4.xfrom
meeseeksmachine:auto-backport-of-pr-3880-on-1.4.x

Conversation

@meeseeksmachine

Copy link
Copy Markdown
Contributor

Backport PR #3880: Fix: Extract some methods from FCLayers for easier inheritance

@lumberbot-app lumberbot-app Bot added cuda tests Run test suite on CUDA on-merge: backport to 1.4.x on-merge: backport to 1.4.x labels Jun 30, 2026
@meeseeksmachine meeseeksmachine added cuda tests Run test suite on CUDA on-merge: backport to 1.4.x on-merge: backport to 1.4.x labels Jun 30, 2026
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.28%. Comparing base (19209f0) to head (fbc22ff).

Files with missing lines Patch % Lines
src/scvi/nn/_base_components.py 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            1.4.x    #3898      +/-   ##
==========================================
+ Coverage   74.23%   74.28%   +0.05%     
==========================================
  Files         231      231              
  Lines       23050    23064      +14     
==========================================
+ Hits        17112    17134      +22     
+ Misses       5938     5930       -8     
Flag Coverage Δ
cuda 74.28% <96.29%> (?)
integration 74.25% <96.29%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/scvi/nn/_base_components.py 94.79% <96.29%> (+0.26%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis merged commit ad5dd8c into scverse:1.4.x Jun 30, 2026
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda tests Run test suite on CUDA on-merge: backport to 1.4.x on-merge: backport to 1.4.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants