fix zarr.open (v3) lacks context manager#327
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the removal of context manager functionality from zarr.open in zarr-python v3 by implementing a workaround that provides the missing context manager behavior.
- Implements a custom
zarr_opencontext manager function to replace directzarr.openusage - Updates all instances of
zarr.opencontext manager usage to use the new workaround function - Ensures proper cleanup of zarr stores when exiting the context
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/spatialdata_io/_utils.py | Adds zarr_open context manager workaround function with proper store cleanup |
| src/spatialdata_io/readers/xenium.py | Updates zarr.open usage to use the new zarr_open context manager |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| try: | ||
| yield f | ||
| finally: | ||
| f.store.close() |
There was a problem hiding this comment.
Calling f.store.close() may fail if the store doesn't have a close() method or if f.store is None. Consider adding a check to ensure the store exists and has a close method before calling it, or wrap in a try-except block to handle potential AttributeError.
Suggested change
| f.store.close() | |
| if f.store is not None and hasattr(f.store, "close"): | |
| f.store.close() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zarr-pythonv3 removed the context manager functionalities fromzarr.open(zarr-developers/zarr-python#2619). This small PR adds a workaround for that.