packaging: fix dev package dependency resolution#456
Merged
wprzytula merged 4 commits intoMay 26, 2026
Conversation
dkropachev
force-pushed
the
fix/dev-package-dependency-resolution
branch
2 times, most recently
from
May 21, 2026 20:37
48e53a3 to
57b5ecf
Compare
dkropachev
marked this pull request as ready for review
May 22, 2026 00:17
dkropachev
force-pushed
the
fix/dev-package-dependency-resolution
branch
from
May 22, 2026 01:37
57b5ecf to
b21ba47
Compare
wprzytula
requested changes
May 22, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes Linux DEB/RPM development package dependency resolution by ensuring the dev packages depend on the corresponding runtime package, and by updating the packaging smoke tests to install the dev package via a temporary local repo so the package manager must resolve/install the runtime dependency.
Changes:
- Add runtime-package dependencies to the DEB
-devand RPM-develpackages in CPack configuration. - Update packaging smoke tests to validate dependency metadata and exercise apt/dnf resolution via a temporary local repository.
- Refresh README + docs installation examples to explicitly install both runtime and development artifacts.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
CMakeLists.txt |
Adds runtime dependency to DEB/RPM dev component metadata so dev packages cannot install without the shared library. |
packaging/smoke-test-app/Makefile |
Enhances smoke tests to validate dev-package dependency fields and install dev packages via temporary apt/dnf repos to exercise resolver behavior. |
Makefile |
Updates package test targets to run new verification steps and rely on dev-package installation to pull in runtime packages. |
README.md |
Updates packaging install instructions to show installing both runtime and dev artifacts. |
docs/source/topics/installation.md |
Updates Linux install commands to match the split runtime/dev packaging outputs. |
docs/source/topics/getting-started.md |
Updates download/install examples to include both runtime and dev packages with the current artifact naming. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dkropachev
force-pushed
the
fix/dev-package-dependency-resolution
branch
2 times, most recently
from
May 22, 2026 15:54
5580b34 to
94b8668
Compare
wprzytula
requested changes
May 22, 2026
dkropachev
force-pushed
the
fix/dev-package-dependency-resolution
branch
3 times, most recently
from
May 22, 2026 16:54
6cca81a to
4e2504d
Compare
wprzytula
requested changes
May 25, 2026
dkropachev
force-pushed
the
fix/dev-package-dependency-resolution
branch
3 times, most recently
from
May 25, 2026 13:45
e164e31 to
ddc6f9a
Compare
Dev packages install link-time files, but the versioned shared library lives in the runtime package. Without an explicit dependency, a dev-only install can miss the runtime library. Add exact DEB/RPM runtime dependencies and keep install docs aligned with resolver-driven dev installs. Co-authored-by: Wojciech Przytuła <woj.przytula@gmail.com>
Make expanded ${package_name} before recipe execution, so validation errors could omit the package label. Escape it as a shell variable.
The smoke tests installed runtime packages directly, so CI could miss broken dev-package dependencies. Verify the dependency metadata and install dev packages from temporary apt/dnf repos so the resolver must pull the runtime package.
The smoke-test labels only feed validation errors, but they still used stale scylla-rs-driver names. Match them to the actual scylla-cpp-driver package names.
dkropachev
force-pushed
the
fix/dev-package-dependency-resolution
branch
from
May 25, 2026 14:27
ddc6f9a to
01e9c04
Compare
wprzytula
reviewed
May 25, 2026
wprzytula
added a commit
to wprzytula/cpp-rs-driver
that referenced
this pull request
Jun 2, 2026
## Summary - add the runtime package dependency to the DEB/RPM dev packages so the unversioned linker symlink and pkg-config files do not install without the shared library - exercise dependency resolution in the smoke tests by installing the dev package through a temporary local repository and letting apt/dnf resolve the runtime package Fixes: scylladb#454 ## Testing - `make test-package-deb` - `make test-package-rpm` ## Notes - macOS packaging was checked separately; it uses split component packages as well, but the current productbuild/DragNDrop flow does not encode equivalent package-manager dependency metadata. (cherry picked from commit 807eed3)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #454
Testing
make test-package-debmake test-package-rpmNotes
Checklist
I have implemented Rust unit tests for the features/changes introduced.I have enabled appropriate tests inMakefilein{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.Fixes:annotations to PR description.