Skip to content

bump Rust Driver to 1.6.0 + later panic fix#462

Merged
wprzytula merged 1 commit into
scylladb:masterfrom
wprzytula:bump-rust-driver-1.6.0-with-panic-fix
Jun 2, 2026
Merged

bump Rust Driver to 1.6.0 + later panic fix#462
wprzytula merged 1 commit into
scylladb:masterfrom
wprzytula:bump-rust-driver-1.6.0-with-panic-fix

Conversation

@wprzytula

@wprzytula wprzytula commented May 26, 2026

Copy link
Copy Markdown
Contributor

CI tests are failing due to a panic in the Rust Driver, which was fixed in scylla-rust-driver/pull/1644, after 1.6.0 was released. This PR updates the driver to commit
e04a12a9950cb3d051288541d5439835098c5cc2 (the newest commit on Rust Driver's main branch), which should fix the CI tests.

Cargo.lock's changes were performed by running:

cargo update -p scylla-cql -p scylla-proxy -p scylla --manifest-path=scylla-rust-wrapper/Cargo.toml

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • PR description sums up the changes and reasons why they should be introduced.
  • [ ] I have implemented Rust unit tests for the features/changes introduced.
  • [ ] I have enabled appropriate tests in Makefile in {SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.
  • [ ] I added appropriate Fixes: annotations to PR description.

@wprzytula
wprzytula requested a review from Copilot May 26, 2026 09:01
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 546776a9-13ed-4cd7-ae0f-4206ab487503

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Pins Scylla Rust dependencies to commit e04a12a9950cb3d051288541d5439835098c5cc2 and updates an integration test to include cassandra.h and use CASS_CONSISTENCY_ALL for validation queries.

Changes

Dependency Revision Updates

Layer / File(s) Summary
Scylla crate revisions update
scylla-rust-wrapper/Cargo.toml
scylla, scylla-proxy, and scylla-cql dependencies updated from v1.5.0 tags to git revision e04a12a9950cb3d051288541d5439835098c5cc2.

Integration test change

Layer / File(s) Summary
test_async include and consistency
tests/src/integration/tests/test_async.cpp
Adds #include "cassandra.h" and changes the validation session_.execute call to include CASS_CONSISTENCY_ALL. Also asserts that awaited Future returns CASS_OK.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hopped through Cargo.toml tonight,
Three crates aligned under one commit light,
A header added, consistency set to all,
Tests and crates answer the rabbit's call,
Small changes stitched — a tidy flight. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating the Rust Driver to version 1.6.0 and including a panic fix, which aligns with the changeset updating Cargo.toml dependencies.
Description check ✅ Passed The PR description includes context for the changes, explains why they are needed (CI test failures due to a panic fix), documents how Cargo.lock was updated, and addresses the pre-review checklist with appropriate markings.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@wprzytula
wprzytula requested a review from Lorak-mmk May 26, 2026 09:01
@wprzytula wprzytula self-assigned this May 26, 2026
@wprzytula wprzytula added this to the 1.1.0 milestone May 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the scylla-rust-wrapper crate to use a newer upstream scylla-rust-driver commit (post-1.6.0) intended to fix a CI-failing panic, and refreshes the lockfile accordingly.

Changes:

  • Pin scylla, scylla-cql, and scylla-proxy git dependencies to commit e04a12a9950cb3d051288541d5439835098c5cc2.
  • Update Cargo.lock to reflect the new scylla* crate versions (1.6.0 / 0.0.6) and updated transitive dependencies.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
scylla-rust-wrapper/Cargo.toml Pins Scylla Rust driver-related git dependencies to the specified upstream commit to pick up the panic fix.
scylla-rust-wrapper/Cargo.lock Lockfile refresh to match the updated driver commit and its transitive dependency graph.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wprzytula
wprzytula force-pushed the bump-rust-driver-1.6.0-with-panic-fix branch from 2a98d81 to ae92850 Compare May 26, 2026 11:44
@wprzytula

Copy link
Copy Markdown
Contributor Author

Rebased on master, with the fix #463.

CI tests are failing due to a panic in the Rust Driver, which was fixed
in scylla-rust-driver/pull/1644, after 1.6.0 was released.
This PR updates the driver to commit
e04a12a9950cb3d051288541d5439835098c5cc2 (the newest commit on Rust
Driver's main branch), which should fix the CI tests.

`Cargo.lock`'s changes were performed by running:
```
cargo update -p scylla-cql -p scylla-proxy -p scylla --manifest-path=scylla-rust-wrapper/Cargo.toml
```
@wprzytula
wprzytula force-pushed the bump-rust-driver-1.6.0-with-panic-fix branch from ae92850 to 938bf62 Compare May 26, 2026 18:05
@wprzytula

Copy link
Copy Markdown
Contributor Author

Force pushed just to trigger the checks, which (no idea why) didn't fire before.

@wprzytula
wprzytula marked this pull request as draft May 29, 2026 07:54
@wprzytula
wprzytula force-pushed the bump-rust-driver-1.6.0-with-panic-fix branch 3 times, most recently from 1f1f9a2 to 938bf62 Compare June 2, 2026 08:38
@wprzytula
wprzytula marked this pull request as ready for review June 2, 2026 08:40
@wprzytula
wprzytula merged commit 9fe3acd into scylladb:master Jun 2, 2026
16 of 19 checks passed
@wprzytula
wprzytula deleted the bump-rust-driver-1.6.0-with-panic-fix branch June 2, 2026 09:02
@wprzytula wprzytula mentioned this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants