Revert "gtest IT: print logs to stderr unconditionally"

[wprzytula]

This reverts commits that introduced unconditional logging to stderr in gtest integration tests:

• 6b9b545,
• 2db8a26,
• 7ffd093.

Rationale:
CI got unstable because two tests that issue many requests (~4000) now timeout every time, because stderr logging (unbuffered!) of each request is too slow.
I'm unable to think of a better way to capture logs in CI, so I'm reverting the change for now and will hopefully look into a more robust solution later.

Pre-review checklist

• I have split my patch into logically separate commits.
• All commit messages clearly explain what they change and why.
• PR description sums up the changes and reasons why they should be introduced.
• [ ] I have implemented Rust unit tests for the features/changes introduced.
• [ ] I have enabled appropriate tests in Makefile in {SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.
• [ ] I added appropriate Fixes: annotations to PR description.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cfceddcb-f429-463b-bd6b-33e72e884aa1

📥 Commits

Reviewing files that changed from the base of the PR and between 18bd75c and 048aa68.

📒 Files selected for processing (1)

• tests/src/integration/logger.cpp

---

📝 Walkthrough

Walkthrough

This pull request makes two minor adjustments to the test logger implementation (tests/src/integration/logger.cpp). It defines platform-specific macros FILE_MODE and LOCALTIME for non-Windows systems using standard POSIX constants and functions, and applies a whitespace formatting adjustment to the log output line that appends file and line number information to log messages. The changes support cross-platform compatibility of the logger test.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the primary change: reverting commits that introduced unconditional stderr logging, which directly corresponds to the changeset's purpose and the main objective.
Description check	✅ Passed	The PR description covers the main changes (three specific commit reverts), provides clear rationale (CI instability from slow unbuffered stderr logging), and includes a partially completed pre-review checklist with appropriate items marked.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Infer (1.2.0)

tests/src/integration/logger.cpp

In file included from tests/src/integration/logger.cpp:17:
In file included from tests/src/integration/logger.hpp:19:
tests/src/integration/objects.hpp:19:10: fatal error: 'cassandra.h' file not found
19 | #include "cassandra.h"
| ^~~~~~~~~~~~~
1 error generated.
Error: the following clang command did not run successfully:
/opt/infer-linux-x86_64-v1.2.0/lib/infer/facebook-clang-plugins/clang/install/bin/clang-18
@/tmp/coderabbit-infer/048aa68890f8908ed75adaf13642baba31dad06f-deff463f166b25fa/tmp/clang_command_.tmp.8c1223.txt
++Contents of '/tmp/coderabbit-infer/048aa68890f8908ed75adaf13642baba31dad06f-deff463f166b25fa/tmp/clang_command_.tmp.8c1223.txt':
"-cc1" "-load"
"/opt/infer-linux-x86_64-v1.2.0/lib/infer/infer/bin/../../facebook-clang-plugins/libtooling/build/FacebookClangPlugin.dylib"
"-add-plugin" "BiniouASTExporter" "-plugin-arg-BiniouASTExporter" "-"
"-plugin-arg-BiniouASTExporter" "PREPEND_CURRENT_DIR=1"
"-plugin-arg-BiniouASTEx

... [truncated 1189 characters] ...

ll/lib/clang/18/include"
"-internal-isystem" "/usr/local/include" "-internal-isystem"
"/usr/lib/gcc/x86_64-linux-gnu/12/../../../../x86_64-linux-gnu/include"
"-internal-externc-isystem" "/usr/include/x86_64-linux-gnu"
"-internal-externc-isystem" "/include" "-internal-externc-isystem"
"/usr/include" "-Wno-ignored-optimization-argument" "-Wno-everything"
"-fdeprecated-macro" "-ferror-limit" "19" "-fgnuc-version=4.2.1"
"-fskip-odr-check-in-gmf" "-fcxx-exceptions" "-fexceptions"
"-D__GCC_HAVE_DWARF2_CFI_ASM=1" "-o"
"/tmp/coderabbit-infer/deff463f166b25fa/file.o" "-x" "c++"
"tests/src/integration/logger.cpp" "-O0" "-fno-builtin" "-include"
"/opt/infer-linux-x86_64-v1.2.0/lib/infer/infer/bin/../lib/clang_wrappers/global_defines.h"
"-Wno-everything"

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR reverts prior changes that printed integration-test driver logs to stderr unconditionally, restoring the previous behavior of writing logs only to the per-test log file. This is intended to address CI instability/timeouts caused by unbuffered stderr output during very high request-volume tests.

Changes:

• Remove unconditional stderr logging (including TTY color detection and UTC timestamp formatting) from the integration test logger callback.
• Remove now-unneeded platform-specific macros/includes used solely for stderr TTY detection and UTC formatting.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.