Skip to content

Commit 1500857

Browse files
nikagradkropachev
authored andcommitted
fix: correct input reference and upload-logs condition in release workflow (3.x)
Two pre-existing bugs in .github/workflows/release.yml: 1. 'Checkout Code One Commit Before' step referenced `inputs.version_tag` in both the step name and RELEASE_TARGET_TAG env var. The actual input is named `target-tag`. Because the wrong expression always evaluates to empty string, the step name appeared as 'Checkout Code One Commit Before ' (trailing space) in CI, and RELEASE_TARGET_TAG was always empty — meaning any re-release triggered with a specific tag would silently check out the wrong commit. Confirmed in run #129 (https://github.com/scylladb/java-driver/actions/runs/25297315236): step 3 is logged as 'Checkout Code One Commit Before ' with no tag value. 2. 'Upload release logs' had `if: failure()` so the artifact was skipped on successful runs. Run #129 shows step 9 'Upload release logs' as skipped despite the release completing successfully. Release logs are useful as an audit trail regardless of outcome (scylla-4.x already uploads unconditionally). Remove the condition to align both branches.
1 parent 82e5ec6 commit 1500857

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

.github/workflows/release.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ jobs:
3333
- name: Checkout Repository
3434
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
3535

36-
- name: Checkout Code One Commit Before ${{ inputs.version_tag }}
36+
- name: Checkout Code One Commit Before ${{ inputs.target-tag }}
3737
if: inputs.target-tag != 'scylla-3.x'
3838
env:
39-
RELEASE_TARGET_TAG: ${{ inputs.version_tag }}
39+
RELEASE_TARGET_TAG: ${{ inputs.target-tag }}
4040
run: make checkout-one-commit-before
4141

4242
- name: Set up Java
@@ -81,7 +81,6 @@ jobs:
8181
run: make release-dry-run
8282

8383
- name: Upload release logs
84-
if: failure()
8584
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
8685
with:
8786
name: maven-stdout

0 commit comments

Comments
 (0)