Commit 1500857
fix: correct input reference and upload-logs condition in release workflow (3.x)
Two pre-existing bugs in .github/workflows/release.yml:
1. 'Checkout Code One Commit Before' step referenced `inputs.version_tag`
in both the step name and RELEASE_TARGET_TAG env var. The actual input
is named `target-tag`. Because the wrong expression always evaluates to
empty string, the step name appeared as 'Checkout Code One Commit Before '
(trailing space) in CI, and RELEASE_TARGET_TAG was always empty — meaning
any re-release triggered with a specific tag would silently check out the
wrong commit.
Confirmed in run #129 (https://github.com/scylladb/java-driver/actions/runs/25297315236):
step 3 is logged as 'Checkout Code One Commit Before ' with no tag value.
2. 'Upload release logs' had `if: failure()` so the artifact was skipped on
successful runs. Run #129 shows step 9 'Upload release logs' as skipped
despite the release completing successfully. Release logs are useful as an
audit trail regardless of outcome (scylla-4.x already uploads
unconditionally). Remove the condition to align both branches.1 parent 82e5ec6 commit 1500857
1 file changed
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
85 | 84 | | |
86 | 85 | | |
87 | 86 | | |
| |||
0 commit comments