Commit a6d0e48
committed
feat: add EndPoint.resolveAll() for multi-address DNS expansion (DRIVER-201)
Addresses the endpoint-API aspect of DRIVER-201.
Problem: EndPoint.resolve() returns a single SocketAddress. When a
hostname maps to multiple IPs, the driver can only try the first one
and fails with AllNodesFailedException if it is unreachable — the
remaining IPs are invisible to the connection layer.
Solution (per @dkropachev's architectural direction):
- Deprecate EndPoint.resolve(). Add EndPoint.resolveAll() with a default
implementation that wraps resolve() in a single-element array for
backward compatibility with third-party implementations.
- DefaultEndPoint.resolveAll(): if the stored InetSocketAddress is
unresolved, calls InetAddress.getAllByName() to expand the hostname
to all known IPs, returning one InetSocketAddress per IP. Falls back
to the single-element unresolved address if DNS fails, so the connect
attempt surfaces a descriptive error rather than returning empty.
- SniEndPoint.resolveAll(): re-resolves the proxy hostname on each call
and returns all A-records sorted by IP, enabling the caller to try
each proxy address in sequence.
- ClientRoutesEndPoint.resolveAll(): delegates to resolve() (single-
address topology-monitor lookup) and wraps in a one-element array.
- ChannelFactory.connect(): replaced endPoint.resolve() with
endPoint.resolveAll(). Iterates through the returned candidates via
tryNextCandidate(); on per-address failure logs and tries the next;
only fails the overall resultFuture when all candidates are exhausted.
Protocol-version negotiation (downgrade retries) is scoped to the
same address via connectToAddress(), which is semantically correct.
Tests:
- DefaultEndPointTest: 3 new cases — already-resolved passthrough,
unresolved hostname expansion, unresolvable hostname fallback.
- SniEndPointTest: new class with cases for resolveAll() happy path,
unresolvable host exception, and resolve() sanity check.
- All 13 existing ChannelFactory tests continue to pass (LocalEndPoint
uses the default single-element resolveAll() via the interface default).1 parent c830c20 commit a6d0e48
13 files changed
Lines changed: 436 additions & 11 deletions
File tree
- core/src
- main/java/com/datastax
- dse/driver
- api/core/auth
- internal/core/insights
- oss/driver
- api/core/metadata
- internal/core
- channel
- metadata
- ssl
- test/java/com/datastax/oss/driver/internal/core
- channel
- metadata
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
291 | 291 | | |
292 | 292 | | |
293 | 293 | | |
| 294 | + | |
| 295 | + | |
294 | 296 | | |
295 | 297 | | |
296 | 298 | | |
| |||
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
288 | 288 | | |
289 | 289 | | |
290 | 290 | | |
| 291 | + | |
| 292 | + | |
291 | 293 | | |
292 | 294 | | |
293 | 295 | | |
| |||
302 | 304 | | |
303 | 305 | | |
304 | 306 | | |
| 307 | + | |
| 308 | + | |
305 | 309 | | |
306 | 310 | | |
307 | 311 | | |
| |||
454 | 458 | | |
455 | 459 | | |
456 | 460 | | |
| 461 | + | |
| 462 | + | |
457 | 463 | | |
458 | 464 | | |
459 | 465 | | |
| |||
Lines changed: 33 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | 21 | | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
26 | 25 | | |
27 | 26 | | |
28 | | - | |
| 27 | + | |
29 | 28 | | |
30 | 29 | | |
31 | 30 | | |
32 | 31 | | |
33 | 32 | | |
34 | 33 | | |
35 | | - | |
| 34 | + | |
36 | 35 | | |
37 | 36 | | |
38 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
39 | 42 | | |
| 43 | + | |
40 | 44 | | |
41 | 45 | | |
42 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
43 | 73 | | |
44 | 74 | | |
45 | 75 | | |
| |||
Lines changed: 116 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
219 | 219 | | |
220 | 220 | | |
221 | 221 | | |
222 | | - | |
| 222 | + | |
223 | 223 | | |
224 | | - | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
225 | 231 | | |
226 | 232 | | |
227 | 233 | | |
228 | 234 | | |
229 | 235 | | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
230 | 335 | | |
231 | 336 | | |
232 | 337 | | |
| |||
235 | 340 | | |
236 | 341 | | |
237 | 342 | | |
238 | | - | |
| 343 | + | |
| 344 | + | |
239 | 345 | | |
240 | 346 | | |
241 | 347 | | |
| |||
294 | 400 | | |
295 | 401 | | |
296 | 402 | | |
297 | | - | |
| 403 | + | |
298 | 404 | | |
299 | 405 | | |
300 | 406 | | |
| |||
307 | 413 | | |
308 | 414 | | |
309 | 415 | | |
310 | | - | |
| 416 | + | |
| 417 | + | |
311 | 418 | | |
312 | 419 | | |
313 | 420 | | |
| |||
316 | 423 | | |
317 | 424 | | |
318 | 425 | | |
319 | | - | |
| 426 | + | |
| 427 | + | |
320 | 428 | | |
321 | | - | |
| 429 | + | |
322 | 430 | | |
323 | 431 | | |
324 | 432 | | |
325 | 433 | | |
326 | 434 | | |
327 | 435 | | |
328 | | - | |
| 436 | + | |
329 | 437 | | |
330 | 438 | | |
331 | 439 | | |
| |||
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
79 | 93 | | |
80 | 94 | | |
81 | 95 | | |
| |||
Lines changed: 44 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
| 25 | + | |
| 26 | + | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
| |||
41 | 44 | | |
42 | 45 | | |
43 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
44 | 88 | | |
45 | 89 | | |
46 | 90 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
701 | 701 | | |
702 | 702 | | |
703 | 703 | | |
| 704 | + | |
| 705 | + | |
704 | 706 | | |
705 | 707 | | |
706 | 708 | | |
| |||
723 | 725 | | |
724 | 726 | | |
725 | 727 | | |
| 728 | + | |
| 729 | + | |
726 | 730 | | |
727 | 731 | | |
728 | 732 | | |
| |||
0 commit comments