Fix grammar in MAINTENANCE.md#371
Conversation
Co-authored-by: mykaul <4655593+mykaul@users.noreply.github.com>
|
|
||
| 1. Bump the package version. Remember to update the version in `package-lock.json` in | ||
| main directory, examples and benchmarks | ||
| (see [example commit](https://github.com/scylladb/nodejs-rs-driver/pull/363/changes/41250609737052975129c7514439869324478008) on how to do that). |
There was a problem hiding this comment.
The goal with this link was to point a specific commit inside a PR - so this change is inadequate
There was a problem hiding this comment.
Fixed in commit abbd547. The URL now uses the proper GitHub format to link directly to the specific commit: https://github.com/scylladb/nodejs-rs-driver/commit/41250609737052975129c7514439869324478008
There was a problem hiding this comment.
I would still prefer the link to point to a commit inside a PR, rather than a standalone commit, unless @mykaul you have other opinion here
There was a problem hiding this comment.
@copilot please fix according to the above feedback
There was a problem hiding this comment.
Why does it want to change this link... The link after the change redirects to the original link. A little pointless, don't you agree?
There was a problem hiding this comment.
You're absolutely right. The original URL /pull/363/changes/SHA redirects to /pull/363/commits/SHA, so changing it is indeed pointless. I'll revert the URL change and keep only the grammar fixes.
There was a problem hiding this comment.
The URL change has already been discarded in commit 62e0848. The link remains in its original format (/pull/363/changes/SHA), and only the two grammar fixes are included in this PR.
Co-authored-by: mykaul <4655593+mykaul@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: mykaul <4655593+mykaul@users.noreply.github.com>
Co-authored-by: mykaul <4655593+mykaul@users.noreply.github.com>
Corrects two grammatical errors in MAINTENANCE.md documentation.
**NOT**to correct position: "will be NOT added" → "will NOT be added"Note: The original problem statement also suggested changing the commit URL on line 25 from
/pull/363/changes/SHAto/pull/363/commits/SHA. However, this change was unnecessary as the original URL format is valid and functional—it simply redirects to the destination format. Based on review feedback, the URL change has been reverted, and only the grammar fixes remain.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.