Skip to content

Prepare documentation for GA#480

Merged
adespawn merged 2 commits into
scylladb:mainfrom
adespawn:prepare-ga
Jun 17, 2026
Merged

Prepare documentation for GA#480
adespawn merged 2 commits into
scylladb:mainfrom
adespawn:prepare-ga

Conversation

@adespawn

Copy link
Copy Markdown
Contributor

No description provided.

@adespawn

Copy link
Copy Markdown
Contributor Author

@annastuchlik This will be the first point of the #471

@adespawn adespawn marked this pull request as ready for review June 17, 2026 09:16
@adespawn adespawn mentioned this pull request Jun 17, 2026
@adespawn adespawn changed the title Prepare readme for GA Prepare documentation for GA Jun 17, 2026
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@adespawn, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 28 minutes and 40 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d5d41009-5d72-4b32-842a-33efa972bb81

📥 Commits

Reviewing files that changed from the base of the PR and between 325cc7a and 958f860.

📒 Files selected for processing (4)
  • README.md
  • docs/source/index.rst
  • docs/source/statements/index.md
  • docs/source/statements/parameterized-queries.md
📝 Walkthrough

Walkthrough

The README and docs landing page (docs/source/index.rst) are updated to describe the driver as production-ready rather than experimental, noting that some optional features remain planned. The documentation section in the README is revised to reference the online docs site with an enumerated list of included materials. The "Features and roadmap" section in both files is expanded with additional bullets covering load balancing, retry policies, address translation, SSL support, driver logging, and faster performance, while the prior "planned for production readiness" subsection is removed in favor of a GitHub Milestones link. A new documentation page for parameterized queries is added at docs/source/statements/parameterized-queries.md, covering positional (?) and named (:name) parameter binding with JavaScript examples, and it is registered in the statements toctree.

Possibly related issues

  • doc: Release the documentation for GA #471: This PR directly addresses the first checklist item by removing the "experimental" designation from README.md and docs/source/index.rst, marking the driver as production-ready ahead of the GA release.

Possibly related PRs

  • scylladb/nodejs-rs-driver#466: Both PRs modify docs/source/index.rst, including overlapping edits to the landing page copy and "Roadmap/Faster performance" bullet content.

Suggested reviewers

  • annastuchlik
  • wprzytula
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess whether the description relates to the changeset. Add a description explaining the documentation updates for GA release, such as the driver status change and new features documentation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating documentation to reflect the driver's transition to General Availability (GA) status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the documentation Improvements or additions to documentation label Jun 17, 2026
@wprzytula wprzytula requested a review from Copilot June 17, 2026 09:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Not ready to approve

The docs build changes are likely to break CI (native build requirement in Sphinx docs flow) and the Sphinx index introduces an unescaped * that can fail -W doc builds.

Pull request overview

Updates the project documentation to reflect General Availability/production-readiness messaging and expands the published docs with an additional Statements subpage.

Changes:

  • Update README and Sphinx landing page wording from “experimental” to “production-ready”, and refresh the feature/roadmap lists.
  • Add a new Statements documentation page covering positional and named parameterized queries and link it from the Statements index.
  • Adjust the docs build Makefile jsdoc target to compile sources before generating API docs.
File summaries
File Description
README.md Updates GA/production-ready messaging and feature list.
docs/source/statements/parametrized-queries.md Adds a new page documenting parameter binding (positional/named).
docs/source/statements/index.md Links the new parameterized-queries page into the Statements toctree.
docs/source/index.rst Updates GA/production-ready messaging and feature/roadmap content for Sphinx docs.
docs/Makefile Changes JSDoc generation flow to include a build step prior to docs generation.

Copilot's findings

  • Files reviewed: 5/5 changed files
  • Comments generated: 7

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/Makefile Outdated
Comment thread docs/source/index.rst
Comment thread docs/source/statements/parametrized-queries.md Outdated
Comment thread docs/source/statements/parametrized-queries.md Outdated
Comment thread docs/source/statements/parametrized-queries.md Outdated
Comment thread docs/source/statements/parametrized-queries.md Outdated
Comment thread docs/source/statements/index.md Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
docs/source/statements/parametrized-queries.md (1)

8-33: ⚖️ Poor tradeoff

Consider documenting error cases and parameter validation.

The parameterized queries guide covers happy-path usage with positional and named parameters, but does not mention potential error scenarios:

  • Mismatched parameter counts (fewer/more parameters than placeholders)
  • Type validation or coercion behavior
  • null/undefined handling
  • Named parameter case handling details (which direction does matching go?)

While the current documentation is adequate for basic usage, consider adding a section on common errors and edge cases to reduce user frustration. This can be deferred as a follow-up enhancement if not critical for the GA release.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/source/statements/parametrized-queries.md` around lines 8 - 33, Add a
new section to the parameterized queries documentation after the existing "Named
parameterized statements" section that documents error cases and edge cases.
This section should cover common issues users may encounter including mismatched
parameter counts (providing fewer or more parameters than placeholders), type
validation and coercion behavior, how null and undefined values are handled, and
clarify the exact case-sensitivity matching behavior for named parameters to
prevent user confusion and reduce support friction.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/source/statements/parametrized-queries.md`:
- Around line 19-33: The documentation file currently uses British English
spelling in its filename with "parametrized" while all content headings such as
"Named parameterized statements" and "Positional parameterized statements" use
American English spelling "Parameterized". To resolve this inconsistency, rename
the current documentation file to use American English spelling to match the
headings and the DataStax upstream documentation reference, and then update the
corresponding toctree reference in the statements index configuration to point
to the renamed file with the corrected spelling.

---

Nitpick comments:
In `@docs/source/statements/parametrized-queries.md`:
- Around line 8-33: Add a new section to the parameterized queries documentation
after the existing "Named parameterized statements" section that documents error
cases and edge cases. This section should cover common issues users may
encounter including mismatched parameter counts (providing fewer or more
parameters than placeholders), type validation and coercion behavior, how null
and undefined values are handled, and clarify the exact case-sensitivity
matching behavior for named parameters to prevent user confusion and reduce
support friction.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d0d61cff-9c5e-402a-bdb6-ce7ad3983236

📥 Commits

Reviewing files that changed from the base of the PR and between 96cf140 and f02dca1.

📒 Files selected for processing (5)
  • README.md
  • docs/Makefile
  • docs/source/index.rst
  • docs/source/statements/index.md
  • docs/source/statements/parametrized-queries.md

Comment thread docs/source/statements/parameterized-queries.md
Comment thread docs/source/index.rst Outdated
Comment thread README.md Outdated
Comment thread README.md
Comment thread docs/source/statements/index.md Outdated
Comment thread docs/source/statements/parametrized-queries.md Outdated
Comment thread docs/Makefile Outdated
Comment thread docs/Makefile

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgarcia360 Please review these changes.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adespawn adespawn force-pushed the prepare-ga branch 2 times, most recently from d2a7bfe to c9cc9c5 Compare June 17, 2026 10:27
Comment thread README.md Outdated
Comment thread docs/source/index.rst Outdated

@annastuchlik annastuchlik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are required to make the docs build - see my comments.

Comment thread docs/source/index.rst Outdated
@adespawn adespawn requested review from wprzytula and removed request for wprzytula June 17, 2026 11:50

@annastuchlik annastuchlik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me now.
We'll fix issue #477 in a follow-up PR.

@adespawn adespawn merged commit 75378b2 into scylladb:main Jun 17, 2026
9 checks passed
@adespawn

Copy link
Copy Markdown
Contributor Author

Bypassed rules, since this PR had @annastuchlik approval, and @wprzytula is not avaliable to approve at this moment: all comments from review were addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants