Skip to content

docs: complie ts inside js-doc script#486

Merged
wprzytula merged 2 commits into
scylladb:mainfrom
dgarcia360:fix-multiversion-ts-docs
Jun 19, 2026
Merged

docs: complie ts inside js-doc script#486
wprzytula merged 2 commits into
scylladb:mainfrom
dgarcia360:fix-multiversion-ts-docs

Conversation

@dgarcia360

@dgarcia360 dgarcia360 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Problem

Multiversion is not publishing reference docs for .ts files.

Fix

Compile ts too in multiversion, not only when building the preview locally.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 91aeb7ba-ced2-4341-b4ac-1b8662e9d4a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dgarcia360

Copy link
Copy Markdown
Contributor Author

Closes #477

@dgarcia360

Copy link
Copy Markdown
Contributor Author

c3b84a8 potentially fixed the issue too. I'll rebase since now the fix would be redundant.

@dgarcia360 dgarcia360 force-pushed the fix-multiversion-ts-docs branch from f221bc7 to 7a8f61b Compare June 18, 2026 10:21
@dgarcia360 dgarcia360 marked this pull request as ready for review June 18, 2026 10:25
@dgarcia360

dgarcia360 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

@annastuchlik @adespawn Consider merging these changes so that it only defines how to build js reference docs in one place.

Also, there's no need to include ./node_modules/.bin/ before tsc. tsc is already available via the typescript dependency.

@dgarcia360 dgarcia360 changed the title docs: complie ts insted js-doc script docs: complie ts inside js-doc script Jun 18, 2026
@annastuchlik

Copy link
Copy Markdown
Contributor

Consider merging these changes so that it only defines how to build js reference docs in one place.

Also, there's no need to include ./node_modules/.bin/ before tsc. tsc is already available via the typescript dependency.

@adespawn @wprzytula Please review and merge this PR. While the current solution is working, it may get us in trouble in the future when we want to update the logic (after full migration to .ts) - and we'll have to remember to update it in two places.

@wprzytula wprzytula merged commit 2a6b6c7 into scylladb:main Jun 19, 2026
8 checks passed
@wprzytula wprzytula added this to the GA (optional) milestone Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants