Skip to content

Remove benchmarking logic from the driver#489

Merged
wprzytula merged 1 commit into
scylladb:mainfrom
adespawn:rm-benchmarks
Jun 19, 2026
Merged

Remove benchmarking logic from the driver#489
wprzytula merged 1 commit into
scylladb:mainfrom
adespawn:rm-benchmarks

Conversation

@adespawn

@adespawn adespawn commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This code was moved to a separate repository.
The python runner is no longer necessary with the new tools for running benchmarks

Fixes: #358 (This is no longer issue for this repository, and probably will have to be re-opened in the benchmarks repo, or we can just ignore it since it's not critical flaw in the internal code)
Fixes: #351

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@adespawn, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 11 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f58f4a10-6b5e-4f59-8223-bcd609adda90

📥 Commits

Reviewing files that changed from the base of the PR and between ddd7eb5 and d185de4.

⛔ Files ignored due to path filters (1)
  • benchmark/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (42)
  • Cargo.toml
  • benchmark/Cargo.toml
  • benchmark/README.md
  • benchmark/logic/batch.js
  • benchmark/logic/benchmark.js
  • benchmark/logic/concurrent_deser.js
  • benchmark/logic/concurrent_insert.js
  • benchmark/logic/concurrent_paging.js
  • benchmark/logic/concurrent_select.js
  • benchmark/logic/concurrent_ser.js
  • benchmark/logic/deser.js
  • benchmark/logic/insert.js
  • benchmark/logic/large_select.js
  • benchmark/logic/paging.js
  • benchmark/logic/parametrized_select.js
  • benchmark/logic/select.js
  • benchmark/logic/ser.js
  • benchmark/logic/utils.js
  • benchmark/logic_rust/batch.rs
  • benchmark/logic_rust/common.rs
  • benchmark/logic_rust/concurrent_deser.rs
  • benchmark/logic_rust/concurrent_insert.rs
  • benchmark/logic_rust/concurrent_paging.rs
  • benchmark/logic_rust/concurrent_select.rs
  • benchmark/logic_rust/concurrent_ser.rs
  • benchmark/logic_rust/deser.rs
  • benchmark/logic_rust/insert.rs
  • benchmark/logic_rust/large_select.rs
  • benchmark/logic_rust/paging.rs
  • benchmark/logic_rust/parametrized_select.rs
  • benchmark/logic_rust/select.rs
  • benchmark/logic_rust/ser.rs
  • benchmark/package.json
  • benchmark/runner-config/cassandra-driver/config.yml
  • benchmark/runner-config/config.yml
  • benchmark/runner-config/run-js-benchmark.sh
  • benchmark/runner-config/run-js-concurrency-benchmark.sh
  • benchmark/runner-config/run-rust-benchmark.sh
  • benchmark/runner-config/run-rust-concurrency-benchmark.sh
  • benchmark/runner-config/rust-driver/config.yml
  • benchmark/runner-config/scylladb-driver/config.yml
  • benchmark/runner.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This code was moved to a separate repository.
The python runner is no longer necessary with the new tools for running benchmarks
@wprzytula wprzytula merged commit 1174164 into scylladb:main Jun 19, 2026
9 checks passed
@adespawn adespawn deleted the rm-benchmarks branch June 20, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsitent formatter in benchmark directory Testing the benchmarks

2 participants