connection: drop async keyspace send cleanup

Author: dkropachev

cassandra/connection.py

@@ -1745,13 +1745,7 @@ def process_result(result):
         # acquire a new request id
         request_id = self.get_request_id()
 
-        try:
-            self.send_msg(query, request_id, process_result)
-        except Exception as exc:
-            with self.lock:
-                if request_id not in self._requests and request_id not in self.request_ids:
-                    self.request_ids.append(request_id)
-            callback(self, exc)
+        self.send_msg(query, request_id, process_result)
 
     @property
     def is_idle(self):

tests/unit/test_connection.py

@@ -389,27 +389,6 @@ def test_wait_for_responses_releases_request_id_when_send_raises_after_registrat
         assert len(c.request_ids) == initial_request_ids
         assert not c._requests
 
-    def test_set_keyspace_async_reports_send_failure_and_releases_request_id(self):
-        c = self.make_connection()
-        c.push = Mock(side_effect=ConnectionException("write failed"))
-        initial_in_flight = c.in_flight
-        initial_request_ids = len(c.request_ids)
-        callback_errors = []
-
-        def callback(conn, error):
-            callback_errors.append(error)
-            with conn.lock:
-                conn.in_flight -= 1
-
-        c.set_keyspace_async("ks", callback)
-
-        assert len(callback_errors) == 1
-        assert isinstance(callback_errors[0], ConnectionException)
-        assert c.in_flight == initial_in_flight
-        assert len(c.request_ids) == initial_request_ids
-        assert not c._requests
-
-
 @patch('cassandra.connection.ConnectionHeartbeat._raise_if_stopped')
 class ConnectionHeartbeatTest(unittest.TestCase):