Skip to content

Commit 6cc6e02

Browse files
committed
fix: keep idle heartbeat test assertions meaningful
1 parent c7252e4 commit 6cc6e02

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

tests/integration/standard/test_cluster.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -771,6 +771,7 @@ def test_idle_heartbeat(self):
771771
# make sure requests were sent on all connections
772772
# Note: connections can be replaced in shard-aware environments, so we skip
773773
# connections that weren't present in the initial snapshot
774+
validated_connections = 0
774775
for c in connections:
775776
conn_id = id(c)
776777
if conn_id not in connection_request_ids:
@@ -780,6 +781,9 @@ def test_idle_heartbeat(self):
780781
expected_ids.rotate(-1)
781782
with c.lock:
782783
assertListEqual(list(c.request_ids), list(expected_ids))
784+
validated_connections += 1
785+
786+
assert validated_connections > 0
783787

784788
# assert idle status
785789
assert all(c.is_idle for c in connections)

0 commit comments

Comments
 (0)