Skip to content

Add LWT support#584

Merged
dkropachev merged 4 commits into
scylladb:masterfrom
sylwiaszunejko:add-lwt-support
Nov 24, 2025
Merged

Add LWT support#584
dkropachev merged 4 commits into
scylladb:masterfrom
sylwiaszunejko:add-lwt-support

Conversation

@sylwiaszunejko

@sylwiaszunejko sylwiaszunejko commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator

Fixes: #476, #475

@sylwiaszunejko sylwiaszunejko marked this pull request as ready for review November 13, 2025 16:37
@sylwiaszunejko

Copy link
Copy Markdown
Collaborator Author

@dkropachev This test keeps failing test_create_session_and_check_system_views_clients even though I haven't change any logic around it, do you have any idea why can this happen?

@dkropachev

Copy link
Copy Markdown
Collaborator

@dkropachev This test keeps failing test_create_session_and_check_system_views_clients even though I haven't change any logic around it, do you have any idea why can this happen?

It is some weird bug, it is also failing on my branch.

@dkropachev dkropachev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, there are some minor changes needed

Comment thread cassandra/protocol_features.py Outdated
Comment thread cassandra/protocol_features.py Outdated
Comment thread tests/integration/standard/test_prepared_statements.py Outdated
Comment thread cassandra/cluster.py Outdated
@dkropachev

dkropachev commented Nov 14, 2025

Copy link
Copy Markdown
Collaborator

@sylwiaszunejko, you also forgot to address batch statement part, but before we go there, could you please run tests for all the cases from https://github.com/scylladb/scylla-drivers/issues/117 and post findings there, after we can discuss what API should look like.

@sylwiaszunejko

sylwiaszunejko commented Nov 17, 2025

Copy link
Copy Markdown
Collaborator Author

@sylwiaszunejko, you also forgot to address batch statement part, but before we go there, could you please run tests for all the cases from scylladb/scylla-drivers#117 and post findings there, after we can discuss what API should look like.

WDYM by batch statements? AFAIU batch statement cannot be lwt or not as a whole

@dkropachev

dkropachev commented Nov 17, 2025

Copy link
Copy Markdown
Collaborator

@sylwiaszunejko, you also forgot to address batch statement part, but before we go there, could you please run tests for all the cases from scylladb/scylla-drivers#117 and post findings there, after we can discuss what API should look like.

WDYM by batch statements? AFAIU batch statement cannot be lwt or not as a whole

They can have serial consistency, which means that they will work same way LWT statements work on the backend.
I know that if one statement of the batch is LWT then whole batch is going to have serial consistency.

Comment thread cassandra/query.py Outdated
@dkropachev

Copy link
Copy Markdown
Collaborator

@sylwiaszunejko, you also forgot to address batch statement part, but before we go there, could you please run tests for all the cases from scylladb/scylla-drivers#117 and post findings there, after we can discuss what API should look like.

WDYM by batch statements? AFAIU batch statement cannot be lwt or not as a whole

They can have serial consistency, which means that they will work same way LWT statements work on the backend. I know that if one statement of the batch is LWT then whole batch is going to have serial consistency.

Let's don't cover batch statements in this PR, we need to test how it works first

@dkropachev dkropachev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes, rest looks good.

Comment thread cassandra/cluster.py Outdated
Comment thread cassandra/protocol.py Outdated
Comment thread cassandra/protocol.py Outdated
Comment thread cassandra/protocol.py Outdated
Comment thread cassandra/lwt_info.py Outdated

@dkropachev dkropachev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one, let's fix and merge

Comment thread cassandra/query.py Outdated
Comment thread cassandra/protocol.py Outdated
@dkropachev dkropachev merged commit 7597059 into scylladb:master Nov 24, 2025
21 checks passed
@sylwiaszunejko sylwiaszunejko self-assigned this Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement SCYLLA_LWT_ADD_METADATA_MARK feature

2 participants