Fix dict hanlding in pool and metrics#595
Merged
Merged
Conversation
sylwiaszunejko
approved these changes
Nov 18, 2025
|
Typo in commit title, otherwise looks OK. |
There are certain rules you need to following in the cases when dicts are modified and read in parallel. Otherwise you end up with `RuntimeError: dictionary changed size during iteration`. Rules are the following: 1. Any iteration over items or keys, needs to be done over a snapshot, i.e. `list()` or `set()` 2. Avoid unnecessary iterations like `len(d.keys())`, you can replace them with `len(d)` This commit fixes code to match these rules in the `pool.py` and `metrics.py`
e90948b to
51fbb77
Compare
Lorak-mmk
approved these changes
Nov 18, 2025
Collaborator
Author
Fixed, pipeline is fialing because of the weird network issue: No changes to the code done since last cicd run. |
|
I would guess cloudflare issues, half of the internet was broken today cause of those
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are certain rules you need to following in the cases when dicts are modified and read in parallel.
Otherwise you end up with
RuntimeError: dictionary changed size during iteration. Rules are the following:list()orset()len(d.keys()), you can replace them withlen(d)This commit fixes code to match these rules in the
pool.pyandmetrics.pyFixes: #594
Pre-review checklist
I added relevant tests for new features and bug fixes.I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.Fixes:annotations to PR description.