control-connection: keep zero-token hosts#844
Closed
dkropachev wants to merge 2 commits into
Closed
Conversation
Collaborator
Author
|
Withdrawing. This PR assumed zero-token nodes should remain in driver topology metadata while being omitted from the token map. That is likely the wrong model here: driver known hosts are query/pool targets, and zero-token nodes should not be added if the driver cannot execute on them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
system.peers,system.peers_v2, local row metadata, and empty token list shapesFixes #843
Driver surface
Control connection topology refresh and token metadata population.
Protocol or compatibility risks
Low. Token map behavior stays unchanged for hosts without tokens; the topology refresh no longer filters valid zero-token hosts from metadata.
Tests
044b625db0332d88a9741c3a707708b73f5d1b53dd140745f211e542e3cb0996Integration scenarios
Not required; this is unit-covered metadata refresh behavior.