Replace SimpleStrategy with NetworkTopologyStrategy#881
Closed
roydahan wants to merge 86 commits into
Closed
Conversation
* update RH nav order * add line break * add api
Added error handling blog reference.
This reverts commit 6894b02.
…ion-specific CLE policies (apache#1165)
…before running integration tests (apache#1202)
…xWarning in Python 3.12 (apache#1205)
before this change, when testing with cqlsh, we have warnings like: ``` <frozen importlib._bootstrap>:488: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC). ```` in this change, we replace the deprecated API with timezone-aware API, to avoid this warning. to keep the backward compatibility, `DateTime.to_python()` still returns an offset-naive timestamp. Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
… allow specifying of libev install via env vars (apache#1223)
…x handling of variable length types (OSS C* 5.0) (apache#1217)
Co-authored-by: Madhavan <msmygit@users.noreply.github.com>
* Run integration tests with HCD 1.0.0 * Apply review comments
… examples, and management code ScyllaDB has deprecated SimpleStrategy. All CREATE KEYSPACE statements now use NetworkTopologyStrategy with replication_factor shorthand. Unit tests updated to use NTS objects with dc-based replication options. The SimpleStrategy class in cassandra/metadata.py is preserved for backward compatibility with Cassandra clusters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimpleStrategyusage withNetworkTopologyStrategyacross tests, examples, benchmarks, andcqlengine/management.py(29 files)SimpleStrategy; allCREATE KEYSPACEstatements now useNetworkTopologyStrategywithreplication_factorshorthand{'dc1': N}instead of{'replication_factor': N})SimpleStrategyclass incassandra/metadata.pyis preserved for backward compatibility with Cassandra clusters