Skip to content

tests: reduce nested type/UDT depth to 12 for new CQL nesting limit#898

Merged
sylwiaszunejko merged 1 commit into
scylladb:masterfrom
sylwiaszunejko:limit-nesting
Jun 10, 2026
Merged

tests: reduce nested type/UDT depth to 12 for new CQL nesting limit#898
sylwiaszunejko merged 1 commit into
scylladb:masterfrom
sylwiaszunejko:limit-nesting

Conversation

@sylwiaszunejko

Copy link
Copy Markdown
Collaborator

Scylla now caps the nesting depth of CQL expressions in the parser, rejecting deeply nested literals with: SyntaxException code=2000 'expression nested too deeply'

Cap the deepest case at 12, the maximum depth the server now allows.

Caused by scylladb/scylladb@c27e322.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Scylla now caps the nesting depth of CQL expressions in the
parser, rejecting deeply nested literals with:
  SyntaxException code=2000 'expression nested too deeply'

Cap the deepest case at 12, the maximum depth the server now allows.

Caused by scylladb/scylladb commit e35c388 ('cql3: limit nesting depth
of function calls and CASTs in CQL parser') scylladb/scylladb@c27e322.
@sylwiaszunejko sylwiaszunejko self-assigned this Jun 10, 2026
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0db95ec5-ab9c-4589-b524-cefbf574c4d8

📥 Commits

Reviewing files that changed from the base of the PR and between c08913b and 995642d.

📒 Files selected for processing (2)
  • tests/integration/standard/test_types.py
  • tests/integration/standard/test_udts.py

📝 Walkthrough

Walkthrough

This PR adjusts test constants for nested type coverage to align with Scylla's CQL expression nesting depth limit of 12. The nested tuple test changes its maximum depth from 32 to 12 (updating schema columns and iteration range) and adds a comment documenting the constraint. Three nested UDT tests similarly reduce their maximum nesting depth parameters from 16 to 12.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: reducing nested type/UDT test depth to 12 due to a new CQL nesting limit.
Description check ✅ Passed The PR description explains the motivation (Scylla's new nesting depth limit), the action taken (capping tests at depth 12), and references the upstream change; however, the pre-review checklist shows gaps in test additions and documentation.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sylwiaszunejko sylwiaszunejko requested a review from Lorak-mmk June 10, 2026 07:43
@sylwiaszunejko sylwiaszunejko merged commit 28ddc07 into scylladb:master Jun 10, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants