Skip to content

CI: skip 32-bit Windows wheel builds#916

Merged
dkropachev merged 1 commit into
masterfrom
fix/skip-win32-wheels
Jun 30, 2026
Merged

CI: skip 32-bit Windows wheel builds#916
dkropachev merged 1 commit into
masterfrom
fix/skip-win32-wheels

Conversation

@mykaul

@mykaul mykaul commented Jun 29, 2026

Copy link
Copy Markdown

The *i686 skip pattern in cibuildwheel config only matches Linux 32-bit identifiers (e.g. cp310-manylinux_i686), not Windows 32-bit which uses win32 (e.g. cp310-win32). Add *win32 to skip 32-bit Windows builds, which fail because:

  • c_shard_info.c uses __uint128_t (GCC extension, unsupported by MSVC)
  • cryptography test dependency fails to build for i686-pc-windows-msvc due to missing OpenSSL

Fixes: #906

The *i686 skip pattern in cibuildwheel config matches only Linux
32-bit identifiers (e.g. cp310-manylinux_i686), not Windows 32-bit
(which uses win32, e.g. cp310-win32). Add *win32 to skip 32-bit
Windows builds, which fail because:
- c_shard_info.c uses __uint128_t (GCC extension, unsupported by MSVC)
- cryptography test dependency fails to build for i686-pc-windows-msvc
  due to missing OpenSSL
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The pyproject.toml file's [tool.cibuildwheel] skip list is extended by adding the *win32 pattern, which instructs cibuildwheel to exclude Win32 wheel builds from the CI build matrix.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: skipping 32-bit Windows wheel builds in CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description clearly summarizes the cibuildwheel change, explains why it is needed, and includes a Fixes annotation.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Lorak-mmk

Copy link
Copy Markdown

Is it a fix for #906 ?

@mykaul

mykaul commented Jun 29, 2026

Copy link
Copy Markdown
Author

Is it a fix for #906 ?

I hope so...

@Lorak-mmk

Copy link
Copy Markdown

Can you add Fixes:?

@dkropachev dkropachev merged commit 6471abe into master Jun 30, 2026
29 checks passed
@dkropachev dkropachev deleted the fix/skip-win32-wheels branch June 30, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows build fails because of Openssl

3 participants