Merge fix/memory-leaks into develop

- Fix: resolve memory leaks and remove debug info leakage (PR dwarvesf#346, Rob Mulder)
- Fix comprehensive memory leaks (adapted from PR dwarvesf#335, huynguyenh)

Addresses the cumulative leak causing 2.89GB memory usage on macOS
Sequoia/Tahoe. Closes upstream dwarvesf#326, dwarvesf#336, dwarvesf#351, dwarvesf#352.

Author: sdenike

LauncherApplication/AppDelegate.swift

@@ -42,7 +42,7 @@ class AppDelegate: NSObject, NSApplicationDelegate {
     }
 
     func applicationWillTerminate(_ aNotification: Notification) {
-        // Insert code here to tear down your application
+        DistributedNotificationCenter.default().removeObserver(self)
     }
 
 

hidden/Extensions/StackView+Extension.swift

@@ -11,6 +11,7 @@ import Cocoa
 extension NSStackView {
     func removeAllSubViews() {
         for view in self.views {
+            NSLayoutConstraint.deactivate(view.constraints)
             view.removeFromSuperview()
         }
     }

hidden/Features/Preferences/PreferencesViewController.swift

@@ -47,6 +47,10 @@ class PreferencesViewController: NSViewController {
         }
     }
 
+    deinit {
+        NotificationCenter.default.removeObserver(self)
+    }
+
     //MARK: - VC Life cycle
     override func viewDidLoad() {
         super.viewDidLoad()

hidden/Features/StatusBar/StatusBarController.swift

@@ -67,16 +67,21 @@ class StatusBarController {
         setupUI()
         setupAlwayHideStatusBar()
         NotificationCenter.default.addObserver(self, selector: #selector(handleScreenParametersChanged), name: NSApplication.didChangeScreenParametersNotification, object: nil)
-        DispatchQueue.main.asyncAfter(deadline: .now() + 1, execute: {
-            self.collapseMenuBar()
-        })
+        DispatchQueue.main.asyncAfter(deadline: .now() + 1) { [weak self] in
+            self?.collapseMenuBar()
+        }
 
         if Preferences.areSeparatorsHidden {hideSeparators()}
         autoCollapseIfNeeded()
     }
 
     deinit {
         NotificationCenter.default.removeObserver(self)
+        timer?.invalidate()
+        timer = nil
+        if let statusItem = self.btnAlwaysHidden {
+            NSStatusBar.system.removeStatusItem(statusItem)
+        }
     }
 
     @objc private func handleScreenParametersChanged() {
@@ -165,8 +170,8 @@ class StatusBarController {
         if isToggle {return}
         isToggle = true
         self.isCollapsed ? self.expandMenubar() : self.collapseMenuBar()
-        DispatchQueue.main.asyncAfter(deadline: .now() + 0.3) {
-            self.isToggle = false
+        DispatchQueue.main.asyncAfter(deadline: .now() + 0.3) { [weak self] in
+            self?.isToggle = false
         }
     }
 
@@ -269,20 +274,19 @@ extension StatusBarController {
     }
     @objc private func toggleStatusBarIfNeeded() {
         updateCollapsedLengths()
-        
+
         if Preferences.alwaysHiddenSectionEnabled {
-            if let existing = self.btnAlwaysHidden {
-                NSStatusBar.system.removeStatusItem(existing)
-            }
-            self.btnAlwaysHidden = NSStatusBar.system.statusItem(withLength: btnAlwaysHiddenLength)
-            if let button = btnAlwaysHidden?.button {
-                button.image = self.imgIconLine
-                button.appearsDisabled = true
+            if self.btnAlwaysHidden == nil {
+                self.btnAlwaysHidden = NSStatusBar.system.statusItem(withLength: btnAlwaysHiddenLength)
+                if let button = btnAlwaysHidden?.button {
+                    button.image = self.imgIconLine
+                    button.appearsDisabled = true
+                }
+                self.btnAlwaysHidden?.autosaveName = "hiddenbar_terminate"
             }
-            self.btnAlwaysHidden?.autosaveName = "hiddenbar_terminate"
         } else {
-            if let existing = self.btnAlwaysHidden {
-                NSStatusBar.system.removeStatusItem(existing)
+            if let statusItem = self.btnAlwaysHidden {
+                NSStatusBar.system.removeStatusItem(statusItem)
             }
             self.btnAlwaysHidden = nil
         }

hidden/Models/GlobalKeybindingPreferences.swift

@@ -20,7 +20,6 @@ struct GlobalKeybindPreferences: Codable, CustomStringConvertible {
     let keyCode : UInt32
 
     var description: String {
-        print(keyCode)
         var stringBuilder = ""
         if self.function {
             stringBuilder += "Fn"