diff --git a/Cargo.lock b/Cargo.lock index 2a0442d20..310899960 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -494,7 +494,7 @@ checksum = "94143f37725109f92c262ed2cf5e59bce7498c01bcc1502d7b9afe439a4e9f49" [[package]] name = "sel4" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "cfg-if", "sel4-config", @@ -504,7 +504,7 @@ dependencies = [ [[package]] name = "sel4-alloca" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "cfg-if", ] @@ -512,7 +512,7 @@ dependencies = [ [[package]] name = "sel4-bitfield-ops" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "rustversion", ] @@ -520,12 +520,12 @@ dependencies = [ [[package]] name = "sel4-build-env" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" [[package]] name = "sel4-capdl-initializer" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "log", "rkyv", @@ -534,13 +534,16 @@ dependencies = [ "sel4-immediate-sync-once-cell", "sel4-immutable-cell", "sel4-logging", + "sel4-no-allocator", + "sel4-phdrs", + "sel4-phdrs-patched", "sel4-root-task", ] [[package]] name = "sel4-capdl-initializer-types" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "miniz_oxide", "rkyv", @@ -552,7 +555,7 @@ dependencies = [ [[package]] name = "sel4-capdl-initializer-types-derive" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "proc-macro2", "quote", @@ -562,7 +565,7 @@ dependencies = [ [[package]] name = "sel4-config" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "prettyplease", "proc-macro2", @@ -576,7 +579,7 @@ dependencies = [ [[package]] name = "sel4-config-data" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "sel4-build-env", "sel4-config-types", @@ -586,7 +589,7 @@ dependencies = [ [[package]] name = "sel4-config-macros" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "fallible-iterator", "proc-macro2", @@ -599,7 +602,7 @@ dependencies = [ [[package]] name = "sel4-config-types" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "serde", ] @@ -607,36 +610,31 @@ dependencies = [ [[package]] name = "sel4-ctors-dtors" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" [[package]] name = "sel4-dlmalloc" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "dlmalloc", "lock_api", ] -[[package]] -name = "sel4-elf-header" -version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" - [[package]] name = "sel4-immediate-sync-once-cell" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" [[package]] name = "sel4-immutable-cell" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" [[package]] name = "sel4-initialize-tls" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "cfg-if", "sel4-alloca", @@ -645,16 +643,21 @@ dependencies = [ [[package]] name = "sel4-logging" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "lock_api", "log", ] +[[package]] +name = "sel4-no-allocator" +version = "0.1.0" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" + [[package]] name = "sel4-panicking" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "cfg-if", "sel4-immediate-sync-once-cell", @@ -665,12 +668,39 @@ dependencies = [ [[package]] name = "sel4-panicking-env" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" + +[[package]] +name = "sel4-phdrs" +version = "0.1.0" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" +dependencies = [ + "sel4-phdrs-constants", +] + +[[package]] +name = "sel4-phdrs-constants" +version = "0.1.0" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" + +[[package]] +name = "sel4-phdrs-patched" +version = "0.1.0" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" +dependencies = [ + "sel4-phdrs", + "sel4-rodata-static", +] + +[[package]] +name = "sel4-rodata-static" +version = "0.1.0" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" [[package]] name = "sel4-root-task" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "sel4", "sel4-dlmalloc", @@ -685,7 +715,7 @@ dependencies = [ [[package]] name = "sel4-root-task-macros" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "proc-macro2", "quote", @@ -695,14 +725,15 @@ dependencies = [ [[package]] name = "sel4-runtime-common" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "cfg-if", "sel4", "sel4-ctors-dtors", - "sel4-elf-header", + "sel4-immutable-cell", "sel4-initialize-tls", "sel4-panicking-env", + "sel4-phdrs", "sel4-stack", "unwinding", ] @@ -710,12 +741,12 @@ dependencies = [ [[package]] name = "sel4-stack" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" [[package]] name = "sel4-sync" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "lock_api", "sel4", @@ -725,7 +756,7 @@ dependencies = [ [[package]] name = "sel4-sys" version = "0.1.0" -source = "git+https://github.com/au-ts/rust-sel4?rev=33cb132571121a8d846ad3be9066617087ee5c32#33cb132571121a8d846ad3be9066617087ee5c32" +source = "git+https://github.com/seL4/rust-sel4?rev=c30d0e44fb32c15239049ce402ef2a8c72499aa3#c30d0e44fb32c15239049ce402ef2a8c72499aa3" dependencies = [ "bindgen", "glob", diff --git a/Cargo.toml b/Cargo.toml index e3c561ebb..166c88961 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -12,12 +12,12 @@ members = [ ] [workspace.dependencies.sel4-capdl-initializer] -git = "https://github.com/au-ts/rust-sel4" -rev = "33cb132571121a8d846ad3be9066617087ee5c32" +git = "https://github.com/seL4/rust-sel4" +rev = "c30d0e44fb32c15239049ce402ef2a8c72499aa3" [workspace.dependencies.sel4-capdl-initializer-types] -git = "https://github.com/au-ts/rust-sel4" -rev = "33cb132571121a8d846ad3be9066617087ee5c32" +git = "https://github.com/seL4/rust-sel4" +rev = "c30d0e44fb32c15239049ce402ef2a8c72499aa3" [profile.release.package.microkit-tool] strip = true diff --git a/tool/microkit/src/capdl/initialiser.rs b/tool/microkit/src/capdl/initialiser.rs index 250203b55..45cca4930 100644 --- a/tool/microkit/src/capdl/initialiser.rs +++ b/tool/microkit/src/capdl/initialiser.rs @@ -8,14 +8,19 @@ use std::ops::Range; use rkyv::util::AlignedVec; -use crate::elf::ElfSegmentData; -use crate::util::round_up; +use crate::elf::{ElfProgramHeader64, ElfSegmentData, PF_R, PHENT_TYPE_LOADABLE, PHENT_TYPE_PHDR}; +use crate::util::{round_up, struct_to_bytes}; use crate::{elf::ElfFile, sel4::PageSize}; use crate::{serialise_ut, UntypedObject}; // Page size used for allocating the spec and embedded frames segments. pub const INITIALISER_GRANULE_SIZE: PageSize = PageSize::Small; +// Magic numbers for the initialiser to identify the data type. +// See rust-sel4 crates/sel4-phdrs/constants/src/lib.rs +const PT_SEL4_CAPDL_SPEC: u32 = 0x64c3_4003; +const PT_SEL4_CAPDL_FRAME_DATA: u32 = 0x64c3_4004; + pub struct CapDLInitialiserSpecMetadata { pub spec_size: u64, } @@ -59,6 +64,7 @@ impl CapDLInitialiser { self.spec_metadata = None; } + // Follow implementation in rust-sel4: crates/sel4-capdl-initializer/add-spec/src/lib.rs let spec_vaddr = self.elf.next_vaddr(INITIALISER_GRANULE_SIZE); let spec_size = spec_payload.len() as u64; self.elf.add_segment( @@ -67,6 +73,7 @@ impl CapDLInitialiser { false, spec_vaddr, ElfSegmentData::RealData(spec_payload.into()), + Some(PT_SEL4_CAPDL_SPEC), ); let embedded_frame_data_vaddr = self.elf.next_vaddr(INITIALISER_GRANULE_SIZE); @@ -76,39 +83,73 @@ impl CapDLInitialiser { false, embedded_frame_data_vaddr, ElfSegmentData::RealData(embedded_frame_data), + Some(PT_SEL4_CAPDL_FRAME_DATA), ); - // These symbol names must match rust-sel4/crates/sel4-capdl-initializer/src/main.rs - self.elf - .write_symbol( - "sel4_capdl_initializer_embedded_frames_data_start", - &embedded_frame_data_vaddr.to_le_bytes(), - ) - .unwrap(); + // Now make the program headers table and inject it into the ELF as the initialiser look at + // it to figure out its virtual address bound, spec location in memory etc. + // It would have been nicer if we can perform this step in ElfFile::reserialise() but + // that function is only relevant for x86. + let phdrs_table_vaddr = self.elf.next_vaddr(INITIALISER_GRANULE_SIZE); + let phdrs_table = self.elf.phdrs_table_serialised(); + // Accounts for a PHENT_TYPE_PHDR meta phdr + PHENT_TYPE_LOADABLE phdr when we eventually inject + // the table as a segment. + let expected_phnum = phdrs_table.len() + 2; + let expected_phdrs_table_size_bytes = size_of::() * expected_phnum; + + let mut phdrs_table_bytes = vec![]; + phdrs_table.iter().for_each(|phdr| { + phdrs_table_bytes.extend(unsafe { struct_to_bytes(&phdr.0) }); + }); + + // Simulate what happens in ElfFile::add_segment() to derive the final program headers table. + // We do this due to a chicken and egg problem, the real program headers table won't be finalised + // until we add it as a segment. But we can't add it as a segment until we finalise it. + phdrs_table_bytes.extend(unsafe { + struct_to_bytes(&ElfProgramHeader64 { + type_: PHENT_TYPE_PHDR, + flags: PF_R, + offset: 0, + vaddr: phdrs_table_vaddr, + paddr: phdrs_table_vaddr, + filesz: expected_phdrs_table_size_bytes as u64, + memsz: expected_phdrs_table_size_bytes as u64, + align: 0, + }) + }); + phdrs_table_bytes.extend(unsafe { + struct_to_bytes(&ElfProgramHeader64 { + type_: PHENT_TYPE_LOADABLE, + flags: PF_R, + offset: 0, + vaddr: phdrs_table_vaddr, + paddr: phdrs_table_vaddr, + filesz: expected_phdrs_table_size_bytes as u64, + memsz: expected_phdrs_table_size_bytes as u64, + align: 0, + }) + }); - self.elf - .write_symbol( - "sel4_capdl_initializer_serialized_spec_data_start", - &spec_vaddr.to_le_bytes(), - ) - .unwrap(); - self.elf - .write_symbol( - "sel4_capdl_initializer_serialized_spec_data_size", - &spec_size.to_le_bytes(), - ) - .unwrap(); + self.elf.add_segment( + true, + false, + false, + phdrs_table_vaddr, + ElfSegmentData::RealData(phdrs_table_bytes), + Some(PHENT_TYPE_PHDR), + ); self.elf .write_symbol( - "sel4_capdl_initializer_image_start", - &self.elf.lowest_vaddr().to_le_bytes(), + "sel4_phdrs_patched__vaddr", + &phdrs_table_vaddr.to_le_bytes(), ) .unwrap(); + self.elf .write_symbol( - "sel4_capdl_initializer_image_end", - &self.elf.highest_vaddr().to_le_bytes(), + "sel4_phdrs_patched__phnum", + &(expected_phnum as u16).to_le_bytes(), ) .unwrap(); diff --git a/tool/microkit/src/elf.rs b/tool/microkit/src/elf.rs index 4ef82d9e0..7fb1a4305 100644 --- a/tool/microkit/src/elf.rs +++ b/tool/microkit/src/elf.rs @@ -62,15 +62,15 @@ struct ElfSectionHeader64 { } #[repr(C, packed)] -struct ElfProgramHeader64 { - type_: u32, - flags: u32, - offset: u64, - vaddr: u64, - paddr: u64, - filesz: u64, - memsz: u64, - align: u64, +pub struct ElfProgramHeader64 { + pub type_: u32, + pub flags: u32, + pub offset: u64, + pub vaddr: u64, + pub paddr: u64, + pub filesz: u64, + pub memsz: u64, + pub align: u64, } #[repr(C, packed)] @@ -100,12 +100,13 @@ struct ElfHeader64 { const ELF_MAGIC: &[u8; 4] = b"\x7FELF"; -const PHENT_TYPE_LOADABLE: u32 = 1; +pub const PHENT_TYPE_LOADABLE: u32 = 1; +pub const PHENT_TYPE_PHDR: u32 = 6; /// ELF program-header flags (`p_flags`) const PF_X: u32 = 0x1; const PF_W: u32 = 0x2; -const PF_R: u32 = 0x4; +pub const PF_R: u32 = 0x4; /// ELF section-header type (`sh_type`) const SHT_PROGBITS: u32 = 0x1; @@ -197,6 +198,12 @@ impl ElfSegment { } } +#[derive(Eq, PartialEq, Clone)] +pub struct ProgramHeader { + pub segment_idx: usize, + pub type_: u32, +} + #[derive(Eq, PartialEq, Clone)] pub struct ElfFile { pub path: PathBuf, @@ -204,6 +211,7 @@ pub struct ElfFile { pub entry: u64, pub machine: u16, pub segments: Vec, + pub program_headers: Vec, symbols: HashMap, } @@ -215,6 +223,7 @@ impl ElfFile { entry, machine, segments: [].into(), + program_headers: [].into(), symbols: HashMap::new(), } } @@ -233,12 +242,24 @@ impl ElfFile { Some(path_for_symbols) => ElfFileReader::from_path(path_for_symbols)?.symbols()?, None => reader.symbols()?, }; + // Initially create a one to one mapping of segments -> program headers. + // So that we can create two program headers of different types that point to the same segment. + let program_headers = segments + .iter() + .enumerate() + .map(|(i, _)| ProgramHeader { + segment_idx: i, + type_: PHENT_TYPE_LOADABLE, + }) + .collect(); + Ok(ElfFile { path: path.to_owned(), word_size: reader.word_size, entry: reader.hdr.entry, machine: reader.hdr.machine, segments, + program_headers, symbols, }) } @@ -502,6 +523,9 @@ impl ElfFile { round_down(self.highest_vaddr() + page_size as u64, page_size as u64) } + /// Add a segment, its data and a corresponding program header with loadable type to the ELF. + /// The caller can pass a Some value to `meta_phdr_type_maybe` to create an additional + /// program header with a specific type identifier. pub fn add_segment( &mut self, read: bool, @@ -509,6 +533,7 @@ impl ElfFile { execute: bool, vaddr: u64, data: ElfSegmentData, + meta_phdr_type_maybe: Option, ) { let r = if read { PF_R } else { 0 }; let w = if write { PF_W } else { 0 }; @@ -522,17 +547,52 @@ impl ElfFile { attrs: r | w | x, }; self.segments.push(elf_segment); + + self.program_headers.push(ProgramHeader { + segment_idx: self.segments.len() - 1, + type_: PHENT_TYPE_LOADABLE, + }); + + if let Some(meta_phdr_type) = meta_phdr_type_maybe { + self.program_headers.push(ProgramHeader { + segment_idx: self.segments.len() - 1, + type_: meta_phdr_type, + }); + } } pub fn loadable_segments(&self) -> Vec<&ElfSegment> { self.segments.iter().filter(|s| s.loadable).collect() } + /// Returns a vec of program headers in ELF format without the file data offset filled and its linked segment. + pub fn phdrs_table_serialised(&self) -> Vec<(ElfProgramHeader64, usize)> { + let mut table = vec![]; + for program_header in self.program_headers.iter() { + let linked_segment = &self.segments[program_header.segment_idx]; + + let phdr = ElfProgramHeader64 { + type_: program_header.type_, + flags: linked_segment.attrs, + offset: 0, + vaddr: linked_segment.virt_addr, + paddr: linked_segment.phys_addr, + filesz: linked_segment.file_size(), + memsz: linked_segment.mem_size(), + align: 0, + }; + + table.push((phdr, program_header.segment_idx)); + } + + table + } + /// Re-create a minimal ELF file with all the program and section headers. pub fn reserialise(&self, out: &std::path::Path) -> Result { let ehsize = size_of::(); - let phnum = self.loadable_segments().len(); + let phnum = self.program_headers.len(); let phentsize = size_of::(); // First entry is reserved, last entry is dummy strtab @@ -587,36 +647,32 @@ impl ElfFile { let mut data_off_watermark = (ehsize as u64) + (phnum as u64) * (phentsize as u64) + (shnum as u64) * (shentsize as u64); - let mut data_offs = [].to_vec(); - // First write out the program headers table + // First thing to do is work out where to place all the data segments + let mut seg_idx_to_data_off: HashMap = Default::default(); for (i, seg) in self.loadable_segments().iter().enumerate() { - let ph_serialised = ElfProgramHeader64 { - type_: PHENT_TYPE_LOADABLE, // loadable - flags: seg.attrs, - offset: data_off_watermark, - vaddr: seg.virt_addr, - paddr: seg.phys_addr, - filesz: seg.file_size(), - memsz: seg.mem_size(), - align: 0, - }; - data_offs.push(data_off_watermark); + seg_idx_to_data_off.insert(i, data_off_watermark); + data_off_watermark += seg.file_size(); + } + + // Then write out the program headers table + for (phdr, seg_idx) in self.phdrs_table_serialised().iter_mut() { + phdr.offset = seg_idx_to_data_off[seg_idx]; + let phdr_type = phdr.type_; elf_file - .write_all(unsafe { struct_to_bytes(&ph_serialised) }) + .write_all(unsafe { struct_to_bytes(phdr) }) .unwrap_or_else(|_| { panic!( - "Failed to write ELF program header #{} for '{}'", - i, + "Failed to write ELF program header type {:x} linked to segment index {} for '{}'", + phdr_type, + seg_idx, out.display() ) }); - - data_off_watermark += seg.file_size(); } - // Then the section headers table, which describe the same thing as the program headers. + // Next step is the section headers table, which describe mostly the same thing as the program headers. // This is needed for U-Boot's `bootelf` command to work properly without adding the `-p` flag // when booting the loader image on ARM and RISC-V platforms. // First entry is reserved! @@ -634,7 +690,7 @@ impl ElfFile { type_: SHT_PROGBITS, flags: seg.section_flags(), addr: seg.phys_addr, - offset: data_offs[i], + offset: seg_idx_to_data_off[&i], size: seg.file_size(), link: 0, info: 0, diff --git a/tool/microkit/src/loader.rs b/tool/microkit/src/loader.rs index 5e4ec89b9..53a2597e2 100644 --- a/tool/microkit/src/loader.rs +++ b/tool/microkit/src/loader.rs @@ -572,6 +572,7 @@ impl<'a> Loader<'a> { true, self.entry, ElfSegmentData::RealData(self.to_bytes()), + None, ); loader_elf