Improve link validator: check asset links and merge validation jobs

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: louis-pre

.github/workflows/generate.yml

@@ -66,8 +66,8 @@ jobs:
           commit_user_name: ${{ secrets.GIT_USER_NAME }}
           commit_user_email: ${{ secrets.GIT_USER_EMAIL }}
           commit_author: ${{ secrets.GIT_USER_NAME }} <${{ secrets.GIT_USER_EMAIL }}>
-  validate-paths:
-    name: Validate paths
+  validate:
+    name: Validate paths and links
     needs: commit
     runs-on: ubuntu-latest
     timeout-minutes: 30
@@ -80,17 +80,5 @@ jobs:
         uses: ./.github/actions/setup
       - name: Validate SUMMARY.md paths
         run: npm run validate-paths
-  validate-links:
-    name: Validate links
-    needs: commit
-    runs-on: ubuntu-latest
-    timeout-minutes: 30
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          ref: ${{ github.head_ref }}
-      - name: Setup
-        uses: ./.github/actions/setup
       - name: Validate cross-site links
         run: npm run validate-links

codegen/validate-links.ts

@@ -88,9 +88,6 @@ function checkRelativeLink(file: string, line: number, rawLink: string): void {
   const linkPath = rawLink.replace(/ "mention"$/, '').split('#')[0]
   if (linkPath == null || linkPath === '') return
 
-  // Skip asset references
-  if (linkPath.includes('.gitbook/assets')) return
-
   // Strip GitBook markdown escapes and decode URL encoding
   const cleanPath = decodeURIComponent(
     linkPath.replaceAll('\\(', '(').replaceAll('\\)', ')').replaceAll('\\', ''),
@@ -99,6 +96,19 @@ function checkRelativeLink(file: string, line: number, rawLink: string): void {
   const fileDir = dirname(file)
   const resolved = resolve(fileDir, cleanPath)
 
+  // Check asset references exist
+  if (linkPath.includes('.gitbook/assets')) {
+    if (!existsSync(resolved)) {
+      brokenLinks.push({
+        file,
+        line,
+        url: rawLink,
+        reason: `Asset not found: ${resolved}`,
+      })
+    }
+    return
+  }
+
   // Check if target exists as file, as README.md in directory, or as directory
   if (!existsSync(resolved) && !existsSync(join(resolved, 'README.md'))) {
     brokenLinks.push({