Move validate to check workflow#1112
Conversation
|
Doesn't the check run before the generate right now? |
It ran after. The validation errors were introduce on main, likely via gitbook? Anyway, it the check is not related to the generate action, it should pass for all commits like a linter would. |
It is though, at least if we link between API pages and guide pages |
|
The model is that the check actions should run on top of a commit and pass/fail the commit. Think of codegen like an automated actor that pushes a commit which then still has to pass all the normal checks. Having validate run after generate breaks this model. The generate worked, but the commit it generated will be "linted" once it's pushed. Then it can be inspected using the normal diff view vs hidden inside the workflow's internal state. |
The bare absolute-URL regex stopped only at whitespace, `)`, and `"`. When a `docs.seam.co/latest/...` URL appeared as anchor text inside HTML (e.g. `>https://docs.seam.co/latest/foo</a></td>`), the match greedily swallowed the trailing tags and reported the malformed path as broken. Adding `<` and `>` to the exclusion set lets the bare URL pattern terminate at the closing `<`, so cross-section absolute URLs in the guides README validate cleanly.
razor-x
force-pushed
the
validate-on-check-workflow
branch
from
41c5a0e to
d9712b3
Compare
3 participants
No description provided.