fix: include angle brackets in URL validation regex#1113
Closed
razor-x wants to merge 1 commit into
Closed
Conversation
The bare absolute-URL regex stopped only at whitespace, `)`, and `"`. When a `docs.seam.co/latest/...` URL appeared as anchor text inside HTML (e.g. `>https://docs.seam.co/latest/foo</a></td>`), the match greedily swallowed the trailing tags and reported the malformed path as broken. Adding `<` and `>` to the exclusion set lets the bare URL pattern terminate at the closing `<`, so cross-section absolute URLs in the guides README validate cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the URL validation regex in the link validator to exclude angle brackets (
<and>) from valid URL characters, preventing malformed URLs from being incorrectly validated.Changes
absoluteUrlPatternregex incodegen/validate-links.tsto add<>to the character exclusion setImplementation Details
The regex pattern now excludes
<>characters alongside the existing exclusions for quotes, backslashes, and whitespace:[^)"<>\\s]+This ensures the link validator correctly identifies and reports malformed URLs that may contain these characters.
https://claude.ai/code/session_01DZTR4oU9UvQMWa3A9XEXLR