option to keep drawing even if the player busted

Author: gtheler

players/08-mimic-the-dealer/blackjack.conf

@@ -1,3 +1,5 @@
 rules = s17
-hands = 1e5
-rng_seed = 12345
+hands = 1e6 
+# rng_seed = 12345
+decks = 0
+

src/blackjack.cpp

@@ -202,7 +202,7 @@ Blackjack::Blackjack(Configuration &conf) : Dealer(conf), rng(dev_random()), fif
 ///conf+quit_when_arranged_cards_run_out+example quit_when_arranged_cards_run_out = false
 ///conf+quit_when_arranged_cards_run_out+example quit_when_arranged_cards_run_out = true
   conf.set(&quit_when_arranged_cards_run_out, {"quit_when_arranged_cards_run_out"});
-  
+
 ///conf+new_hand_reset_cards+usage `new_hand_reset_cards_out = ` $b$
 ///conf+new_hand_reset_cards+details If the are arranged cards (either with `cards` or `cards_file`) and $b$ is `true`
 ///conf+new_hand_reset_cards+details then when a hand is finished, the next hand starts with the arranged cards from the very beginning.
@@ -226,6 +226,19 @@ Blackjack::Blackjack(Configuration &conf) : Dealer(conf), rng(dev_random()), fif
 ///conf+new_hand_reset_cards+example new_hand_reset_cards = true
   conf.set(&new_hand_reset_cards, {"new_hand_reset_cards"});
 
+///conf+dealer_draws_even_if_player_busted+usage `dealer_draws_even_if_player_busted = ` $b$
+///conf+dealer_draws_even_if_player_busted+details The usual rule in casinos is that if all player busted all hands (including split hands),
+///conf+dealer_draws_even_if_player_busted+details the dealer does not have to draw until sixteen (or soft seventeen) but the hand is finihsed
+///conf+dealer_draws_even_if_player_busted+details and the next card in the shoe (or shuffler) is the player's first card of the next hand.
+///conf+dealer_draws_even_if_player_busted+details Yet, this rule may distort some statistics such as dealer's bust rate because for sure
+///conf+dealer_draws_even_if_player_busted+details he will not bust that hand.
+///conf+dealer_draws_even_if_player_busted+details This flag can modify the dealer's behavior and, if true, the dealer will draw cards
+///conf+dealer_draws_even_if_player_busted+details as normal even if the player had busted all her hands.
+///conf+dealer_draws_even_if_player_busted+default `false`
+///conf+dealer_draws_even_if_player_busted+example dealer_draws_even_if_player_busted = false
+///conf+dealer_draws_even_if_player_busted+example dealer_draws_even_if_player_busted = true
+  conf.set(&dealer_draws_even_if_player_busted, {"dealer_draws_even_if_player_busted"});
+
   // read arranged cards
 ///conf+cards+usage `cards = ` $\text{list of cards}$
 ///conf+cards+details If this option is given, the dealer draws the cards specified on the list.
@@ -249,10 +262,14 @@ Blackjack::Blackjack(Configuration &conf) : Dealer(conf), rng(dev_random()), fif
 ///conf+cards+details     ii. a set of infinite cards , if `decks` is zero.
 ///conf+cards+details   b. the hand is over and `new_hand_reset_cards` is `true`, or
 ///conf+cards+details   c. `quit_when_arranged_cards_run_out` is true, in which case the program exits.
+///conf+cards+details @
+///conf+cards+details A zero or `XX` means a placeholder for an actual random card. So for example `JS XX AC` will give
+///conf+cards+details the Jack of Spades, a random card and te Ace of Clubs.
+///conf+cards+details @
 ///conf+cards+default Empty list
 ///conf+cards+example cards = TH JD 6C
-///conf+cards+example cards = 2S 5D QS AC
-///conf+cards+example cards = 8D QH TC 2C KD 7S 8S TD AH 5C
+///conf+cards+example cards = 2S XX QS AC
+///conf+cards+example cards = 8D QH XX 2C KD 7S XX TD AH 5C
   if (conf.exists("cards")) {
     if (conf.exists("cards_file")) {
       std::cerr << "error: cannot have both cards and cards_file" << std::endl;
@@ -373,25 +390,27 @@ int Blackjack::read_arranged_cards(std::istringstream iss) {
       if (rank == 'X') {    // placeholder for random
         n = 0;
       } else if (rank == 'A') {
-        n = 1;    
+        n = 1;
       } else if (rank == 'T') {
-        n = 10;    
+        n = 10;
       } else if (rank == 'J') {
-        n = 11;    
+        n = 11;
       } else if (rank == 'Q') {
-        n = 12;    
+        n = 12;
       } else if (rank == 'K') {
-        n = 13;    
+        n = 13;
       } else {
         n = rank - '0';
       }
-      if (n < 1 || n > 13) {
+      if (n < 0 || n > 13) {
         std::cerr << "error: invalid ASCII card rank " << token << std::endl;
         return 1;
       }
 
       if (suit != '\0') {
-        if (suit == 'C') {
+        if (suit == 'X') {
+          n += 0;
+        } else if (suit == 'C') {
           n += static_cast<int>(lbj::Suit::Clubs) * 13;
         } else if (suit == 'D') {
           n += static_cast<int>(lbj::Suit::Diamonds) * 13;
@@ -699,38 +718,42 @@ void Blackjack::deal(void) {
       } else {
         // assume the player busted in all the hands
         bool player_busted_all_hands = true;
-        for (auto playerHand = playerStats.hands.begin(); playerHand != playerStats.hands.end(); playerHand++) {
+        for (const auto &player_hand : playerStats.hands) {
           // if he (she) did not bust, set to false
-          if (playerHand->busted() == false) {
+          if (player_hand.busted() == false) {
             player_busted_all_hands = false;
             break;
           }
         }
 
         if (player_busted_all_hands) {
-          if (enhc == false) {  
+          if (enhc == false) {
             info(lbj::Info::CardDealerRevealsHole, dealer_hole_card);
 #ifdef BJDEBUG
             std::cout << "hole " << card[dealer_hole_card].utf8() << std::endl;
 #endif
           }
-//          } else {
-            playerStats.bustsPlayerAllHands++;
-//          }
-          
-          player->actionRequired = lbj::PlayerActionRequired::None;
-          nextAction = lbj::DealerAction::StartNewHand;
-          return;
+          playerStats.bustsPlayerAllHands++;
+
+          if (dealer_draws_even_if_player_busted) {
+            player->actionRequired = lbj::PlayerActionRequired::None;
+            nextAction = lbj::DealerAction::HitDealerHand;
+            return;
+          } else {
+            player->actionRequired = lbj::PlayerActionRequired::None;
+            nextAction = lbj::DealerAction::StartNewHand;
+            return;
+          }
         }  else {
           player->actionRequired = lbj::PlayerActionRequired::None;
           nextAction = lbj::DealerAction::HitDealerHand;
           return;
         }
-      }        
+      }
     break;
-    
+
     case lbj::DealerAction::HitDealerHand:
-        
+
       if (enhc == false) {
         info(lbj::Info::CardDealerRevealsHole, dealer_hole_card);
 #ifdef BJDEBUG
@@ -740,11 +763,12 @@ void Blackjack::deal(void) {
 
       // hit while count is less than 17 (or equal to soft 17 if hit_soft_17 is true)
       player->value_dealer = hand.value();
-      while ((std::abs(player->value_dealer) < 17 || (h17 && player->value_dealer == -17)) && hand.busted() == 0) {
-        unsigned int dealerCard = draw(&hand);
-        info(lbj::Info::CardDealer, dealerCard);
+      // while ((std::abs(dealer_value) < 17 || (h17 && dealer_value == -17)) && hand.busted() == false) {
+      while (std::abs(player->value_dealer) < 17 || (h17 && player->value_dealer == -17)) {
+        unsigned int dealer_card = draw(&hand);
+        info(lbj::Info::CardDealer, dealer_card);
 #ifdef BJDEBUG
-        std::cout << "dealer " << card[dealerCard].utf8() << std::endl;
+        std::cout << "dealer " << card[dealer_card].utf8() << std::endl;
 #endif
         player->value_dealer = hand.value();
       }
@@ -780,7 +804,7 @@ void Blackjack::deal(void) {
       if (hand.busted()) {
         info(lbj::Info::DealerBusts, player->value_dealer);
         playerStats.bustsDealer++;
-        for (auto playerHand : playerStats.hands) {
+        for (const auto &playerHand : playerStats.hands) {
           if (playerHand.busted() == false) {
             // pay him (her)
             playerStats.bankroll += 2 * playerHand.bet;

src/blackjack.h

@@ -65,6 +65,7 @@ class Blackjack : public Dealer {
     bool shuffle_every_hand = false;
     bool quit_when_arranged_cards_run_out = false;
     bool new_hand_reset_cards = true;
+    bool dealer_draws_even_if_player_busted = false;
 
     std::vector<int> arranged_cards;
     size_t n_arranged_cards = 0; // just to prevent calling size() each time we draw a card

src/dealer.h

@@ -154,36 +154,36 @@ class Hand {
     std::list<unsigned int> cards;
 
     // inline on purpose
-    int value() {
+    int value() const {
       unsigned int soft = 0;
       unsigned int n = 0;
       unsigned int value = 0;
-      for (auto tag : cards) {
+      for (const auto &tag : cards) {
         value = card[tag].value;
         n += value;
         soft += (value == 11);
       }
-     
+
       // this loop should be only executed once if everything works fine
       while (n > 21 && soft > 0){
         n -= 10;
         soft--;
       }
-      
+
       return (soft)?(-n):(n);
     };
-    
+
     // inline on purpose
-    bool blackjack() {
+    bool blackjack() const {
       return (std::abs(value()) == 21 && cards.size() == 2);
     };
-    
+
     // inline on purpose
-    bool busted() {
+    bool busted() const {
       return (std::abs(value()) > 21);
     }
-};    
-    
+};
+
 class PlayerHand : public Hand {
   public:
     PlayerHand(std::size_t i = 0) : id(i) { };

src/report.cpp

@@ -66,35 +66,26 @@ void Dealer::prepareReport(void) {
 
   report.push_back(reportItem(3, "busts_player_n",     playerStats.bustsPlayer));
   report.push_back(reportItem(3, "busts_dealer_n",     playerStats.bustsDealer));
-  
+
   report.push_back(reportItem(3, "busts_player",       playerStats.bustsPlayer / total));
-  report.push_back(reportItem(3, "busts_player_nobj",  playerStats.bustsPlayer / (total - playerStats.blackjacksPlayer)));
+  report.push_back(reportItem(3, "busts_player_all",   playerStats.bustsPlayerAllHands / total));
+  report.push_back(reportItem(3, "busts_dealer",       playerStats.bustsDealer / total));
 
-  double b1 = playerStats.bustsDealer / total;
-  double b2 = playerStats.bustsDealer / (total - playerStats.bustsPlayerAllHands);
-  double b3 = playerStats.bustsDealer / (total - playerStats.blackjacksDealer);
-  double b4 = playerStats.bustsDealer / (total - playerStats.bustsPlayerAllHands - playerStats.blackjacksDealer);
-  
-//  double b2 = b1 * (1 + (double)playerStats.bustsPlayerAllHands/total);
-//  double b3 = b2 * (1 + (double)playerStats.blackjacksDealer/total);
-  report.push_back(reportItem(3, "busts_dealer1",          b1));
-  // report.push_back(reportItem(3, "busts_dealer2old",       playerStats.bustsDealer / (double) (n_hand - playerStats.bustsPlayerAllHands)));
-  report.push_back(reportItem(3, "busts_dealer2",       b2));
-  // report.push_back(reportItem(3, "busts_dealer3old",       playerStats.bustsDealer / (double) (n_hand - playerStats.bustsPlayerAllHands - playerStats.blackjacksDealer)));
-  report.push_back(reportItem(3, "busts_dealer3",       b3));
-  report.push_back(reportItem(3, "busts_dealer3",       b4));
+  report.push_back(reportItem(3, "busts_player_nobust",       playerStats.bustsPlayer / (total - playerStats.blackjacksDealer)));
+  report.push_back(reportItem(3, "busts_dealer_nobust",       playerStats.bustsDealer / (total - playerStats.blackjacksPlayer)));
+
+  report.push_back(reportItem(4, "blackjacks_player",      playerStats.blackjacksPlayer / total));
+  report.push_back(reportItem(4, "blackjacks_dealer",      playerStats.blackjacksDealer / total));
+//  if (playerStats.bustsPlayerAllHands != 0) {
+    // report.push_back(reportItem(4, "blackjacks_dealer_real1", playerStats.blackjacksDealer / (double) (n_hand - playerStats.bustsPlayerAllHands)));
+    // report.push_back(reportItem(4, "blackjacks_dealer_real2", playerStats.blackjacksDealer / (double) (n_hand - playerStats.bustsPlayer)));
+//  }
 
   report.push_back(reportItem(3, "wins",         playerStats.wins / total));
   report.push_back(reportItem(3, "pushes",       playerStats.pushes / total));
   report.push_back(reportItem(3, "losses",       playerStats.losses / total));
 
   report.push_back(reportItem(4, "total_money_waged",      playerStats.totalMoneyWaged));
-  report.push_back(reportItem(4, "blackjacks_player",      playerStats.blackjacksPlayer / total));
-  report.push_back(reportItem(4, "blackjacks_dealer",      playerStats.blackjacksDealer / total));
-//  if (playerStats.bustsPlayerAllHands != 0) {
-    report.push_back(reportItem(4, "blackjacks_dealer_real1", playerStats.blackjacksDealer / (double) (n_hand - playerStats.bustsPlayerAllHands)));
-    report.push_back(reportItem(4, "blackjacks_dealer_real2", playerStats.blackjacksDealer / (double) (n_hand - playerStats.bustsPlayer)));
-//  }
 
   report.push_back(reportItem(5, "variance",  playerStats.variance));
   report.push_back(reportItem(5, "deviation", sqrt(playerStats.variance)));