client: add tls_server_name option#3019
Draft
mcluseau wants to merge 1 commit into
Draft
Conversation
Owner
|
Thanks! I wonder, I suspect people would need a different server name per connection, not the same one for every connection, ya? That feels like it'd be more complicated to expose... |
Author
|
my rationale was that it usually is in a TLS config anyway (from what remember of my golang days), people can just use another Client instance. |
Author
|
but I'm 100% ok to go the Request way :) |
Author
|
The rabbit hole is deeper, I have to first make a change in hyper_tls. |
mcluseau
force-pushed
the
master
branch
2 times, most recently
from
7f310cd to
7913bd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
it seems using a custom TLS ServerName is supported by both
rustlsandnative-tls.This is my attempt to provide an option to set it at the client's level. I didn't see any TLS-specific options in
Request, it may be better there instead. I'll just let you tell me :)