run array_unique() only once per class#1088
Closed
staabm wants to merge 1 commit intosebastianbergmann:mainfrom
Closed
run array_unique() only once per class#1088staabm wants to merge 1 commit intosebastianbergmann:mainfrom
staabm wants to merge 1 commit intosebastianbergmann:mainfrom
Conversation
staabm
commented
Aug 28, 2025
| $classes[$parentClass->namespacedName()], | ||
| ); | ||
|
|
||
| foreach ($merged as $mergedFile => $lines) { |
Contributor
Author
There was a problem hiding this comment.
this loop moved after the outer loop
staabm
commented
Aug 28, 2025
|
|
||
| foreach ($merged as $mergedFile => $lines) { | ||
| $merged[$mergedFile] = array_unique($lines); | ||
| if (!isset($classesThatExtendClass[$parentClass->namespacedName()])) { |
Contributor
Author
There was a problem hiding this comment.
moved this if-condition, so we reflect the same structure as the foreach-loop above (just readability)
Contributor
Author
|
we need to be more incremental as our problem is memory, not cpu: #1089 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
at this point its mostly guess work.
having loops after each other should be faster then nested loops though - O(3n) vs. O(n^2).