Faster MapBuilder::build()#1089
Merged
sebastianbergmann merged 2 commits intosebastianbergmann:mainfrom Aug 29, 2025
Merged
Conversation
Contributor
Author
|
with the last commit I think the implementation got a bit easier. |
MapBuilder::build()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testing with https://github.com/staabm/php-code-coverage-bug1062 reveleaed:
before 6afb0db we fatal errored
since 6afb0db we de-duplicate the array contents earlier which means less memory required while working -> we ran the repro without fatal error
with this PR we prevent unnecessary work and run twice as fast as with 6afb0db