Fix issues reported by PHPStan

Author: sebastianbergmann

src/Framework/RepeatTestSuite.php

@@ -103,6 +103,9 @@ public function setDependencies(array $dependencies): void
         }
     }
 
+    /**
+     * @return non-empty-string
+     */
     public function name(): string
     {
         return $this->tests[0]::class . '::' . $this->tests[0]->nameWithDataSet();

src/Framework/TestSuite.php

@@ -538,6 +538,7 @@ public function isForTestClass(): bool
     /**
      * @param ReflectionClass<TestCase> $class
      * @param list<non-empty-string>    $groups
+     * @param positive-int              $numberOfRuns
      *
      * @throws Exception
      */

src/Runner/Filter/NameFilterIterator.php

@@ -57,14 +57,12 @@ public function accept(): bool
             return true;
         }
 
-        if (!$test instanceof TestCase) {
-            return false;
-        }
-
         if ($test instanceof RepeatTestSuite) {
             $name = $test->name();
-        } else {
+        } elseif ($test instanceof TestCase) {
             $name = $test::class . '::' . $test->nameWithDataSet();
+        } else {
+            return false;
         }
 
         $accepted = @preg_match($this->regularExpression, $name, $matches) === 1;

src/TextUI/Configuration/Cli/Configuration.php

@@ -155,6 +155,10 @@
     private ?bool $noLogging;
     private ?bool $processIsolation;
     private ?int $randomOrderSeed;
+
+    /**
+     * @var ?positive-int
+     */
     private ?int $repeat;
     private ?bool $reportUselessTests;
     private ?bool $resolveDependencies;
@@ -206,6 +210,7 @@
      * @param ?non-empty-list<non-empty-string>                    $testsUsing
      * @param ?non-empty-list<non-empty-string>                    $testsRequiringPhpExtension
      * @param ?non-empty-array<non-empty-string, non-empty-string> $iniSettings
+     * @param ?positive-int                                        $repeat
      * @param ?non-empty-list<non-empty-string>                    $testSuffixes
      * @param ?non-empty-list<non-empty-string>                    $coverageFilter
      * @param ?non-empty-list<non-empty-string>                    $extensions
@@ -2208,6 +2213,8 @@ public function hasRepeat(): bool
 
     /**
      * @throws Exception
+     *
+     * @return positive-int
      */
     public function repeat(): int
     {