Return early

Author: sebastianbergmann

src/Runner/CodeCoverage.php

@@ -412,32 +412,38 @@ public function generateReports(Printer $printer, Configuration $configuration):
 
     public function warnIfFilterIsNotConfigured(CodeCoverageFilterRegistry $codeCoverageFilterRegistry, Configuration $configuration): void
     {
-        if ($codeCoverageFilterRegistry->get()->isEmpty()) {
-            if (!$codeCoverageFilterRegistry->configured()) {
-                EventFacade::emitter()->testRunnerTriggeredPhpunitWarning(
-                    'No filter is configured, code coverage will not be processed',
-                );
-            } else {
-                $paths = [];
+        if (!$codeCoverageFilterRegistry->get()->isEmpty()) {
+            return;
+        }
 
-                foreach ($configuration->source()->includeDirectories() as $directory) {
-                    $paths[] = $directory->path();
-                }
+        if (!$codeCoverageFilterRegistry->configured()) {
+            EventFacade::emitter()->testRunnerTriggeredPhpunitWarning(
+                'No filter is configured, code coverage will not be processed',
+            );
 
-                foreach ($configuration->source()->includeFiles() as $file) {
-                    $paths[] = $file->path();
-                }
+            $this->deactivate();
 
-                EventFacade::emitter()->testRunnerTriggeredPhpunitWarning(
-                    sprintf(
-                        'Configured source filter (include-path: %s) does not match any files, code coverage will not be processed',
-                        implode(', ', $paths),
-                    ),
-                );
-            }
+            return;
+        }
 
-            $this->deactivate();
+        $paths = [];
+
+        foreach ($configuration->source()->includeDirectories() as $directory) {
+            $paths[] = $directory->path();
+        }
+
+        foreach ($configuration->source()->includeFiles() as $file) {
+            $paths[] = $file->path();
         }
+
+        EventFacade::emitter()->testRunnerTriggeredPhpunitWarning(
+            sprintf(
+                'Configured source filter (include-path: %s) does not match any files, code coverage will not be processed',
+                implode(', ', $paths),
+            ),
+        );
+
+        $this->deactivate();
     }
 
     private function activate(Filter $filter, bool $pathCoverage): void