Make check for hidden directory explicit and portable

Author: sebastianbergmann

src/TextUI/Configuration/SourceMapper.php

@@ -9,11 +9,14 @@
  */
 namespace PHPUnit\TextUI\Configuration;
 
+use const DIRECTORY_SEPARATOR;
 use function file_get_contents;
 use function file_put_contents;
 use function is_array;
+use function preg_match;
 use function realpath;
 use function serialize;
+use function str_replace;
 use function unserialize;
 use SebastianBergmann\FileIterator\Facade as FileIteratorFacade;
 use SplObjectStorage;
@@ -80,13 +83,19 @@ public function map(Source $source): array
         $directories = $this->aggregateDirectories($source->includeDirectories());
 
         foreach ($directories as $path => [$prefixes, $suffixes]) {
+            $basePath = realpath($path);
+
             foreach ((new FileIteratorFacade)->getFilesAsArray($path, $suffixes, $prefixes) as $file) {
                 $file = realpath($file);
 
                 if (!$file) {
                     continue;
                 }
 
+                if ($this->isInHiddenDirectory($file, $basePath)) {
+                    continue;
+                }
+
                 $files[$file] = true;
             }
         }
@@ -178,6 +187,15 @@ public function mapForCodeCoverage(Source $source): array
         return $files;
     }
 
+    private function isInHiddenDirectory(string $path, false|string $basePath): bool
+    {
+        $relativePath = str_replace((string) $basePath, '', $path);
+
+        $separator = DIRECTORY_SEPARATOR === '\\' ? '\\\\' : '/';
+
+        return preg_match('=' . $separator . '\.[^' . $separator . ']*' . $separator . '=', $relativePath) === 1;
+    }
+
     /**
      * @return array<string,array{list<string>,list<string>}>
      */

tests/unit/TextUI/SourceMapperTest.php

@@ -73,10 +73,7 @@ public static function provider(): Generator
             ),
         ];
 
-        $fileHiddenOnUnix = self::fixturePath('a/c/.hidden/PrefixSuffix.php');
-
         $expectedFiles = [
-            $fileHiddenOnUnix                                => true,
             self::fixturePath('a/PrefixSuffix.php')          => true,
             self::fixturePath('a/c/Prefix.php')              => true,
             self::fixturePath('a/c/PrefixSuffix.php')        => true,
@@ -92,10 +89,6 @@ public static function provider(): Generator
             self::fixturePath('b/f/h/PrefixSuffix.php')      => true,
         ];
 
-        if (PHP_OS_FAMILY !== 'Windows') {
-            unset($expectedFiles[$fileHiddenOnUnix]);
-        }
-
         yield 'file included using directory' => [
             $expectedFiles,
             self::createSource(
@@ -112,7 +105,6 @@ public static function provider(): Generator
         ];
 
         $expectedFiles = [
-            $fileHiddenOnUnix                                => true,
             self::fixturePath('a/c/Prefix.php')              => true,
             self::fixturePath('a/c/PrefixSuffix.php')        => true,
             self::fixturePath('a/c/Suffix.php')              => true,
@@ -127,10 +119,6 @@ public static function provider(): Generator
             self::fixturePath('b/f/h/PrefixSuffix.php')      => true,
         ];
 
-        if (PHP_OS_FAMILY !== 'Windows') {
-            unset($expectedFiles[$fileHiddenOnUnix]);
-        }
-
         yield 'file included using directory, but excluded using file' => [
             $expectedFiles,
             self::createSource(