Closes #6601

Author: sebastianbergmann

ChangeLog-12.5.md

@@ -11,6 +11,7 @@ All notable changes of the PHPUnit 12.5 release series are documented in this fi
 ### Fixed
 
 * [#6595](https://github.com/sebastianbergmann/phpunit/issues/6595): Crash when before-class or after-class method fails with assertion failure
+* [#6601](https://github.com/sebastianbergmann/phpunit/issues/6601): Anonymous classes are not rejected with a clear error when creating a test double
 * `MockBuilder::setMockClassName()` and `TestStubBuilder::setStubClassName()` now reject values that are not valid unqualified PHP class identifiers, throwing the new `InvalidClassNameException`
 * The regular expression used by `Generator::ensureValidMethods()` to validate method names passed to `MockBuilder::onlyMethods()` and `addMethods()` was not anchored, so any string containing a valid identifier substring (including strings with parentheses, braces, comments, or newlines) was accepted
 

src/Framework/MockObject/Generator/Exception/ClassIsAnonymousException.php

@@ -0,0 +1,30 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of PHPUnit.
+ *
+ * (c) Sebastian Bergmann <sebastian@phpunit.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace PHPUnit\Framework\MockObject\Generator;
+
+use function sprintf;
+
+/**
+ * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
+ *
+ * @internal This class is not covered by the backward compatibility promise for PHPUnit
+ */
+final class ClassIsAnonymousException extends \PHPUnit\Framework\Exception implements Exception
+{
+    public function __construct(string $className)
+    {
+        parent::__construct(
+            sprintf(
+                'Class "%s" is an anonymous class and cannot be doubled',
+                $className,
+            ),
+        );
+    }
+}

src/Framework/MockObject/Generator/Generator.php

@@ -80,6 +80,7 @@ final class Generator
      * @param ?list<non-empty-string> $methods
      * @param array<mixed>            $arguments
      *
+     * @throws ClassIsAnonymousException
      * @throws ClassIsEnumerationException
      * @throws ClassIsFinalException
      * @throws DuplicateMethodException
@@ -199,6 +200,7 @@ public function testDoubleForInterfaceIntersection(array $interfaces, bool $mock
      * @param class-string            $type
      * @param ?list<non-empty-string> $methods
      *
+     * @throws ClassIsAnonymousException
      * @throws ClassIsEnumerationException
      * @throws ClassIsFinalException
      * @throws ReflectionException
@@ -337,6 +339,7 @@ private function instantiate(DoubledClass $mockClass, bool $mockObject, bool $ca
      * @param class-string            $type
      * @param ?list<non-empty-string> $explicitMethods
      *
+     * @throws ClassIsAnonymousException
      * @throws ClassIsEnumerationException
      * @throws ClassIsFinalException
      * @throws MethodNamedMethodException
@@ -369,6 +372,10 @@ private function generateCodeForTestDoubleClass(string $type, bool $mockObject,
 
         $class = $this->reflectClass($_mockClassName['fullClassName']);
 
+        if ($class->isAnonymous()) {
+            throw new ClassIsAnonymousException($_mockClassName['fullClassName']);
+        }
+
         if ($class->isEnum()) {
             throw new ClassIsEnumerationException($_mockClassName['fullClassName']);
         }

src/Framework/MockObject/MockBuilder.php

@@ -11,6 +11,7 @@
 
 use function assert;
 use PHPUnit\Framework\InvalidArgumentException;
+use PHPUnit\Framework\MockObject\Generator\ClassIsAnonymousException;
 use PHPUnit\Framework\MockObject\Generator\ClassIsEnumerationException;
 use PHPUnit\Framework\MockObject\Generator\ClassIsFinalException;
 use PHPUnit\Framework\MockObject\Generator\DuplicateMethodException;
@@ -49,6 +50,7 @@ public function __construct(TestCase $testCase, string $type)
     /**
      * Creates a mock object using a fluent interface.
      *
+     * @throws ClassIsAnonymousException
      * @throws ClassIsEnumerationException
      * @throws ClassIsFinalException
      * @throws DuplicateMethodException

src/Framework/MockObject/TestStubBuilder.php

@@ -10,6 +10,7 @@
 namespace PHPUnit\Framework\MockObject;
 
 use function assert;
+use PHPUnit\Framework\MockObject\Generator\ClassIsAnonymousException;
 use PHPUnit\Framework\MockObject\Generator\ClassIsEnumerationException;
 use PHPUnit\Framework\MockObject\Generator\ClassIsFinalException;
 use PHPUnit\Framework\MockObject\Generator\DuplicateMethodException;
@@ -35,6 +36,7 @@ final class TestStubBuilder extends TestDoubleBuilder
     /**
      * Creates a test stub using a fluent interface.
      *
+     * @throws ClassIsAnonymousException
      * @throws ClassIsEnumerationException
      * @throws ClassIsFinalException
      * @throws DuplicateMethodException

tests/end-to-end/regression/6601.phpt

@@ -0,0 +1,29 @@
+--TEST--
+https://github.com/sebastianbergmann/phpunit/issues/6601
+--FILE--
+<?php declare(strict_types=1);
+$_SERVER['argv'][] = '--do-not-cache-result';
+$_SERVER['argv'][] = '--no-configuration';
+$_SERVER['argv'][] = __DIR__ . '/6601/Issue6601Test.php';
+
+require_once __DIR__ . '/../../bootstrap.php';
+
+(new PHPUnit\TextUI\Application)->run($_SERVER['argv']);
+--EXPECTF--
+PHPUnit %s by Sebastian Bergmann and contributors.
+
+Runtime: %s
+
+E                                                                   1 / 1 (100%)
+
+Time: %s, Memory: %s
+
+There was 1 error:
+
+1) PHPUnit\TestFixture\Issue6601\Issue6601Test::testOne
+PHPUnit\Framework\MockObject\Generator\ClassIsAnonymousException: Class "PHPUnit\TestFixture\Issue6601\Customizable@anonymous%sIssue6601Test.php:%d%s" is an anonymous class and cannot be doubled
+
+%sIssue6601Test.php:%d
+
+ERRORS!
+Tests: 1, Assertions: 0, Errors: 1.

tests/end-to-end/regression/6601/Issue6601Test.php

@@ -0,0 +1,33 @@
+<?php declare(strict_types=1);
+/*
+ * This file is part of PHPUnit.
+ *
+ * (c) Sebastian Bergmann <sebastian@phpunit.de>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace PHPUnit\TestFixture\Issue6601;
+
+use PHPUnit\Framework\TestCase;
+use stdClass;
+
+interface Customizable
+{
+    public function customize(): void;
+}
+
+final class Issue6601Test extends TestCase
+{
+    public function testOne(): void
+    {
+        $object = new class implements Customizable
+        {
+            public function customize(?stdClass $custom = null): void
+            {
+            }
+        };
+
+        self::createMock($object::class);
+    }
+}

tests/unit/Framework/MockObject/Creation/CreateMockTest.php

@@ -12,6 +12,7 @@
 use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\Medium;
 use PHPUnit\Framework\Attributes\TestDox;
+use PHPUnit\Framework\MockObject\Generator\ClassIsAnonymousException;
 use PHPUnit\Framework\MockObject\Generator\ClassIsEnumerationException;
 use PHPUnit\Framework\MockObject\Generator\ClassIsFinalException;
 use PHPUnit\Framework\MockObject\Generator\UnknownTypeException;
@@ -77,6 +78,16 @@ public function testCannotCreateMockObjectForEnumeration(): void
         $this->createMock(Enumeration::class);
     }
 
+    public function testCannotCreateMockObjectForAnonymousClass(): void
+    {
+        $object = new class extends ExtendableClass
+        {};
+
+        $this->expectException(ClassIsAnonymousException::class);
+
+        $this->createMock($object::class);
+    }
+
     public function testCannotCreateMockObjectForUnknownType(): void
     {
         $this->expectException(UnknownTypeException::class);

tests/unit/Framework/MockObject/Creation/CreateStubTest.php

@@ -12,6 +12,7 @@
 use PHPUnit\Framework\Attributes\Group;
 use PHPUnit\Framework\Attributes\Medium;
 use PHPUnit\Framework\Attributes\TestDox;
+use PHPUnit\Framework\MockObject\Generator\ClassIsAnonymousException;
 use PHPUnit\Framework\MockObject\Generator\ClassIsEnumerationException;
 use PHPUnit\Framework\MockObject\Generator\ClassIsFinalException;
 use PHPUnit\Framework\MockObject\Generator\UnknownTypeException;
@@ -74,6 +75,16 @@ public function testCannotCreateTestStubForEnumeration(): void
         $this->createStub(Enumeration::class);
     }
 
+    public function testCannotCreateTestStubForAnonymousClass(): void
+    {
+        $object = new class extends ExtendableClass
+        {};
+
+        $this->expectException(ClassIsAnonymousException::class);
+
+        $this->createStub($object::class);
+    }
+
     public function testCannotCreateTestStubForUnknownType(): void
     {
         $this->expectException(UnknownTypeException::class);