Support for partially ordered parameter sets in mock object expectations#6606
Closed
laloona wants to merge 9 commits into
Closed
Support for partially ordered parameter sets in mock object expectations#6606laloona wants to merge 9 commits into
laloona wants to merge 9 commits into
Conversation
…eterSetsInPartialOrder
…m/laloona/phpunit into parameter-sets-with-partial-order * 'parameter-sets-with-partial-order' of https://github.com/laloona/phpunit: (23 commits) Closes sebastianbergmann#6605 Fix errors reported by PHPStan Activate more rules Update tools Report errors and failures as soon as possible Narrow types for provided data Increase PHPStan Rule Level to 10 Refactor Increase PHPStan Rule Level to 9 Refactor Increase PHPStan Rule Level to 8 Refactor Increase PHPStan Rule Level to 7 Refactor Update dependencies Refactor Return early Improve type annotations Assert that we have a current element Refactor ... # Conflicts: # src/Framework/MockObject/Runtime/Rule/UnorderedParameterSets.php
API Surface ChangesIf any of the additions below are not intended as public API, mark them with New API SurfaceMethods
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6606 +/- ##
============================================
+ Coverage 96.82% 96.84% +0.01%
- Complexity 8446 8475 +29
============================================
Files 859 861 +2
Lines 26055 26125 +70
============================================
+ Hits 25228 25300 +72
+ Misses 827 825 -2 ☔ View full report in Codecov by Sentry. |
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from PR 6604.
I changed to API to that:
So
Assert::fixedis removed.Additional I removed the duplication of the exception.
The index in
IndexedParametersis moved to the constructor, so it can't be null now.I hope the naming for the tests is now more consistent.
I noticed that the
@param list<mixed> $parametersis correct. When we enter the construct $parameters are not clearly defined as they represent argument sets.